SLVS-1679 Enable issue streaming for SLCore analysis #5876
Conversation
| @@ -92,12 +88,10 @@ public void Accept(string path, IEnumerable<IAnalysisIssue> issues) | |||
|
|
|||
| Debug.Assert(issues.All(IsIssueFileLevelOrInAnalysisSnapshot), "Not all reported issues could be mapped to the analysis snapshot"); | |||
|
|
|||
| var newIssues = issues | |||
| allIssues = issues | |||
There was a problem hiding this comment.
Previously, all of the different 'analyzers' were publishing to the same issue consumer, so it needed to be accumulating. Now, we only have one analyzer, which posts all issues for all languages for the file, meaning we no longer need to accumulate
| @@ -78,12 +78,6 @@ private bool IsValid<T>(RaiseFindingParams<T> parameters) where T : RaisedFindin | |||
| return false; | |||
| } | |||
|
|
|||
| if (parameters.isIntermediatePublication) | |||
There was a problem hiding this comment.
With the change to IssueConsumer, we can stop ignoring the intermediate events. This allows us to have issue streaming from SLCore
|
georgii-borovinskikh-sonarsource
requested a review
from gabriela-trutan-sonarsource
georgii-borovinskikh-sonarsource
marked this pull request as ready for review
| @@ -142,7 +142,7 @@ private void HandleAnalysisIssue(Message message) | |||
| // TextBufferIssueTracker when the file was closed, but the TextBufferIssueTracker will | |||
| // still exist and handle the call. | |||
| // todo https://sonarsource.atlassian.net/browse/SLVS-1661 | |||
There was a problem hiding this comment.
Please remove the TODO
There was a problem hiding this comment.
Why? This links to the cleanup task
There was a problem hiding this comment.
You added it after you commented out the line 145 in this commit: 30e2dd5
Then you added back the line, so I assumed the TODO also has to be removed.
If that is not the case, then consider explaining what has to be done in the line and update the task SLVS-1661 to make sure the TODO will be removed
There was a problem hiding this comment.
The whole class needs to be removed, I reverted the line change because I didn't want to comment out the tests
There was a problem hiding this comment.
Then, just update the corresponding Jira task, and everything should be fine. 👍
src/SLCore.Listeners.UnitTests/Implementation/Analysis/RaisedFindingProcessorTests.cs
Show resolved
Hide resolved
georgii-borovinskikh-sonarsource
merged commit eafc02f
into
feature/cfamily-migration
SLVS-1679