Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONARPHP-1530 S1125 should raise an issue when a boolean literal is used in a xor expression #1334

Merged
merged 1 commit into from
Dec 3, 2024
Merged

SONARPHP-1530 S1125 should raise an issue when a boolean literal is used in a xor expression #1334

merged 1 commit into from
Dec 3, 2024

Conversation

jonas-wielage-sonarsource
Copy link
Contributor

@jonas-wielage-sonarsource jonas-wielage-sonarsource commented Dec 3, 2024 •
edited by jira bot
Loading

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title S1125 should raise an issue when a boolean literal is used in a xor expression SONARPHP-1591 S1125 should raise an issue when a boolean literal is used in a xor expression Dec 3, 2024
@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Dec 3, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

rudy-regazzoni-sonarsource
rudy-regazzoni-sonarsource approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonas-wielage-sonarsource jonas-wielage-sonarsource changed the title SONARPHP-1591 S1125 should raise an issue when a boolean literal is used in a xor expression SONARPHP-1530 S1125 should raise an issue when a boolean literal is used in a xor expression Dec 3, 2024
@jonas-wielage-sonarsource jonas-wielage-sonarsource merged commit fd46c0a into master Dec 3, 2024
20 checks passed
@jonas-wielage-sonarsource jonas-wielage-sonarsource deleted the SONARPHP-1530 branch December 3, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudy-regazzoni-sonarsource rudy-regazzoni-sonarsource rudy-regazzoni-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonas-wielage-sonarsource @rudy-regazzoni-sonarsource