SONARPHP-1530 S1125 should raise an issue when a boolean literal is u…

…sed in a xor expression (#1334)
SonarSource · Dec 3, 2024 · fd46c0a · fd46c0a
1 parent 914bb6b
commit fd46c0a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/php-checks/src/main/java/org/sonar/php/checks/BooleanEqualityComparisonCheck.java b/php-checks/src/main/java/org/sonar/php/checks/BooleanEqualityComparisonCheck.java
@@ -36,7 +36,8 @@ public class BooleanEqualityComparisonCheck extends PHPVisitorCheck {
     Kind.ALTERNATIVE_CONDITIONAL_AND,
     Kind.EQUAL_TO,
     Kind.NOT_EQUAL_TO,
-    Kind.ALTERNATIVE_NOT_EQUAL_TO
+    Kind.ALTERNATIVE_NOT_EQUAL_TO,
+    Kind.ALTERNATIVE_CONDITIONAL_XOR
   };
 
   @Override

diff --git a/php-checks/src/test/resources/checks/BooleanEqualityComparisonCheck.php b/php-checks/src/test/resources/checks/BooleanEqualityComparisonCheck.php
@@ -18,6 +18,8 @@
   || b
   || true;        // Noncompliant
 (a || true) ? b : c; // Noncompliant
+true xor a;       // Noncompliant
+$a xor false;     // Noncompliant
 
 a === false;      // OK - exception
 a === true;       // OK - exception