Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor modules to publish two extensions #41

Merged
merged 1 commit into from
Jan 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/modules/ROOT/pages/index.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@ TIP: Solace Quarkus Extension for integrating with Solace PubSub+ message broker

== Installation

If you want to use this extension, you need to add the `com.solace.quarkus:quarkus-solace` extension first to your build file.
If you want to use this extension, you need to add the `com.solace.quarkus:quarkus-solace-client` extension first to your build file.
Copy link
Collaborator

@SravanThotakura05 SravanThotakura05 Jan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add quarkus-solace-messaging-connector reference as well. We need both the artifacts to spin up a connector right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ozangunalp are we adding this in this PR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think overall it'd be better to rewrite that doc page. This is just a replace for the artifact-id

Copy link
Collaborator

@SravanThotakura05 SravanThotakura05 Jan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's cover this as part of #37


For instance, with Maven, add the following dependency to your POM file:

[source,xml,subs=attributes+]
----
<dependency>
<groupId>com.solace.quarkus</groupId>
<artifactId>quarkus-solace</artifactId>
<artifactId>quarkus-solace-client</artifactId>
<version>{project-version}</version>
</dependency>
----
Expand Down
7 changes: 6 additions & 1 deletion docs/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,12 @@
<!-- Make sure the doc is built after the other artifacts -->
<dependency>
<groupId>com.solace.quarkus</groupId>
<artifactId>quarkus-solace-deployment</artifactId>
<artifactId>quarkus-solace-client-deployment</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>com.solace.quarkus</groupId>
<artifactId>quarkus-solace-messaging-connector-deployment</artifactId>
<version>${project.version}</version>
</dependency>
</dependencies>
Expand Down
2 changes: 1 addition & 1 deletion integration-tests/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<version>999-SNAPSHOT</version>
</parent>
<artifactId>quarkus-solace-integration-tests-parent</artifactId>
<name>Quarkus - Solace - Integration Tests - Parent</name>
<name>Quarkus Solace - Integration Tests - Parent</name>
<packaging>pom</packaging>
<modules>
<module>solace-client-integration-tests</module>
Expand Down
3 changes: 2 additions & 1 deletion integration-tests/solace-client-integration-tests/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
</parent>

<artifactId>solace-client-integration-tests</artifactId>
<name>Quarkus Solace Client - Integration Tests</name>

<dependencies>
<dependency>
Expand All @@ -19,7 +20,7 @@
</dependency>
<dependency>
<groupId>com.solace.quarkus</groupId>
<artifactId>quarkus-solace</artifactId>
<artifactId>quarkus-solace-client</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
Expand Down
5 changes: 2 additions & 3 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,8 @@
<name>Quarkus Solace - Parent</name>

<modules>
<module>deployment</module>
<module>runtime</module>
<module>pubsub-plus-connector</module>
<module>quarkus-solace-client</module>
<module>quarkus-solace-messaging-connector</module>
<module>docs</module>
<module>samples/hello-solace</module>
<module>samples/hello-connector-solace</module>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>com.solace.quarkus</groupId>
<artifactId>quarkus-solace-parent</artifactId>
<artifactId>quarkus-solace-client-parent</artifactId>
<version>999-SNAPSHOT</version>
</parent>
<artifactId>quarkus-solace-deployment</artifactId>
<name>Quarkus Solace - Deployment</name>
<artifactId>quarkus-solace-client-deployment</artifactId>
<name>Quarkus Solace Client - Deployment</name>
<dependencies>
<dependency>
<groupId>io.quarkus</groupId>
Expand All @@ -20,7 +20,7 @@
</dependency>
<dependency>
<groupId>com.solace.quarkus</groupId>
<artifactId>quarkus-solace</artifactId>
<artifactId>quarkus-solace-client</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@

class SolaceProcessor {

private static final String FEATURE = "solace";
private static final String FEATURE = "solace-client";

private static final ParameterizedType SOLACE_CUSTOMIZER_INJECTION_TYPE = ParameterizedType.create(
DotName.createSimple(Instance.class),
Expand Down
20 changes: 20 additions & 0 deletions quarkus-solace-client/pom.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd"
xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>com.solace.quarkus</groupId>
<artifactId>quarkus-solace-parent</artifactId>
<version>999-SNAPSHOT</version>
</parent>
<artifactId>quarkus-solace-client-parent</artifactId>
<name>Quarkus Solace Client - Parent</name>
<packaging>pom</packaging>

<modules>
<module>deployment</module>
<module>runtime</module>
</modules>

</project>
6 changes: 3 additions & 3 deletions runtime/pom.xml → quarkus-solace-client/runtime/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>com.solace.quarkus</groupId>
<artifactId>quarkus-solace-parent</artifactId>
<artifactId>quarkus-solace-client-parent</artifactId>
<version>999-SNAPSHOT</version>
</parent>
<artifactId>quarkus-solace</artifactId>
<name>Quarkus Solace - Runtime</name>
<artifactId>quarkus-solace-client</artifactId>
<name>Quarkus Solace Client - Runtime</name>
<dependencies>
<dependency>
<groupId>io.quarkus</groupId>
Expand Down
39 changes: 39 additions & 0 deletions quarkus-solace-messaging-connector/deployment/pom.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>com.solace.quarkus</groupId>
<artifactId>quarkus-solace-messaging-connector-parent</artifactId>
<version>999-SNAPSHOT</version>
</parent>
<artifactId>quarkus-solace-messaging-connector-deployment</artifactId>
<name>Quarkus Solace Messaging Connector - Deployment</name>
<dependencies>
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-smallrye-reactive-messaging-deployment</artifactId>
</dependency>
<dependency>
<groupId>com.solace.quarkus</groupId>
<artifactId>quarkus-solace-client-deployment</artifactId>
<version>${project.version}</version>
</dependency>
</dependencies>
<build>
<plugins>
<plugin>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<annotationProcessorPaths>
<path>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-extension-processor</artifactId>
<version>${quarkus.version}</version>
</path>
</annotationProcessorPaths>
</configuration>
</plugin>
</plugins>
</build>
</project>
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
package com.solace.quarkus.messaging.deployment;

import io.quarkus.deployment.annotations.BuildStep;
import io.quarkus.deployment.builditem.FeatureBuildItem;

public class SolaceMessagingProcessor {

public static final String FEATURE = "solace-messaging-connector";

@BuildStep
FeatureBuildItem feature() {
return new FeatureBuildItem(FEATURE);
}

}
19 changes: 19 additions & 0 deletions quarkus-solace-messaging-connector/pom.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>com.solace.quarkus</groupId>
<artifactId>quarkus-solace-parent</artifactId>
<version>999-SNAPSHOT</version>
</parent>
<artifactId>quarkus-solace-messaging-connector-parent</artifactId>
<name>Quarkus Solace Messaging Connector - Parent</name>
<packaging>pom</packaging>

<modules>
<module>deployment</module>
<module>runtime</module>
</modules>

</project>
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,11 @@
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>com.solace.quarkus</groupId>
<artifactId>quarkus-solace-parent</artifactId>
<artifactId>quarkus-solace-messaging-connector-parent</artifactId>
<version>999-SNAPSHOT</version>
</parent>

<artifactId>quarkus-solace-messaging-connector</artifactId>
<name>Quarkus Solace Messaging Connector</name>

<name>Quarkus Solace Messaging Connector - Runtime</name>
<dependencies>
<dependency>
<groupId>io.smallrye.config</groupId>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
name: Solace Messaging Connector
description: Solace Quarkus Messaging Connector Extension for integrating with Solace PubSub+ message brokers with Reactive Messaging.
metadata:
keywords:
- "solace"
- "pubsubplus event broker"
# guide: https://quarkiverse.github.io/quarkiverse-docs/solace/dev/ # To create and publish this guide, see https://github.com/quarkiverse/quarkiverse/wiki#documenting-your-extension
categories:
- "messaging"
status: "preview"
config:
- "mp.messaging."
- "quarkus.reactive-messaging."
2 changes: 1 addition & 1 deletion samples/hello-connector-solace/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
</dependency>
<dependency>
<groupId>com.solace.quarkus</groupId>
<artifactId>quarkus-solace</artifactId>
<artifactId>quarkus-solace-client</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
Expand Down
2 changes: 1 addition & 1 deletion samples/hello-solace/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
</dependency>
<dependency>
<groupId>com.solace.quarkus</groupId>
<artifactId>quarkus-solace</artifactId>
<artifactId>quarkus-solace-client</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
Expand Down
Loading