Refactor modules to publish two extensions #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozangunalp
changed the title
ozangunalp
force-pushed
the
refactor_extensions
branch
from
1ad0a75
to
e728d1c
Compare
| @@ -7,15 +7,15 @@ TIP: Solace Quarkus Extension for integrating with Solace PubSub+ message broker | |||
|
|
|||
| == Installation | |||
|
|
|||
| If you want to use this extension, you need to add the `com.solace.quarkus:quarkus-solace` extension first to your build file. | |||
| If you want to use this extension, you need to add the `com.solace.quarkus:quarkus-solace-client` extension first to your build file. | |||
There was a problem hiding this comment.
We should also add quarkus-solace-messaging-connector reference as well. We need both the artifacts to spin up a connector right?
There was a problem hiding this comment.
@ozangunalp are we adding this in this PR?
There was a problem hiding this comment.
I think overall it'd be better to rewrite that doc page. This is just a replace for the artifact-id
There was a problem hiding this comment.
Okay, let's cover this as part of #37
|
Looks like there are few conflicts. The conflicts are based on last PR we merged yesterday |
- Quarkus Solace Client - Quarkus Solace Messaging Connector
ozangunalp
force-pushed
the
refactor_extensions
branch
from
e728d1c
to
de4b880
Compare
|
Resolved the conflict. |
SravanThotakura05
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves files around, probably in conflict with the current active PR #40