Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compatibility layer for buildStiffnessMatrix #82

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Add compatibility layer for buildStiffnessMatrix #82

merged 1 commit into from
Nov 10, 2023

Conversation

alxbilger
Copy link
Member

For components not implementing it already

Those component will need to implement buildStiffnessMatrix properly. This PR is just a workaround to make it work in the meantime.

@alxbilger
Add compatibility layer for buildStiffnessMatrix
4769435 
For components not implementing it already
@VannesteFelix
Copy link
Collaborator

Seems great ! thank you @alxbilger.
I will make some test to see how the scene behave.
And side node about that, I want to automate this scene testing in the github action in the future.

@alxbilger
Copy link
Member Author

@VannesteFelix did you have the chance to test scenes?

@VannesteFelix
Copy link
Collaborator

@alxbilger seems fine, merging

@VannesteFelix VannesteFelix merged commit 11fa735 into SofaDefrost:master Nov 10, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alxbilger @VannesteFelix