Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove python2 #80

Merged
merged 2 commits into from
Oct 17, 2023
Merged

remove python2 #80

merged 2 commits into from
Oct 17, 2023

Conversation

VannesteFelix
Copy link
Collaborator

Old python folder unused and won't be in the future: deleted and rename python3 folder to python

  • remove old mor/python lib
  • rename python3 -> python
  • make according changes in cmake
  • change python3 reference to new path in project

@VannesteFelix
remove python2:
cd4603f 
- remove old mor/python lib
- rename python3 -> python
- make according changes in cmake
- change python3 reference to new path in project
alxbilger
alxbilger reviewed Oct 16, 2023
View reviewed changes
Copy link
Member

@alxbilger alxbilger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you use git mv?

@VannesteFelix
Copy link
Collaborator Author

Yes I did and unfortunatly the result seems chaotic...

@VannesteFelix VannesteFelix merged commit 9212fd2 into SofaDefrost:master Oct 17, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxbilger alxbilger alxbilger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VannesteFelix @alxbilger