Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python pipeline #79

Merged
merged 5 commits into from
Oct 17, 2023
Merged

Fix python pipeline #79

merged 5 commits into from
Oct 17, 2023

Conversation

VannesteFelix
Copy link
Collaborator

Not clean but allows to make reduction process.

  • Will need to change a bit the architecture later when listOfActiveNode & reduced mass will be implemented again in a new c++ component.
  • Some python3 fixe
  • Update on exemple scene

- commented out MMM references
- removed precomputed mass, need to be implemented again in C++
- fix python issue with filter
- one with prefab, which does not currently work for the reduction
- one without that work -> diamondRobot.py
self.reductionParam.massName = glob.glob(results[self.phaseToSaveIndex]["directory"]+slash+"*_reduced.txt")[0]
# print("massName -----------------------> ",self.reductionParam.massName)
u.copy(self.reductionParam.massName,self.reductionParam.dataDir)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really need this commented code?

tools/sofa_test_scene/diamondRobot.py Outdated Show resolved Hide resolved
dt=1.0,
gravity=[0.0, 0.0, -9810.0])

# not in Mainheader anymore, need some update
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# not in Mainheader anymore, need some update

Co-authored-by: Alex Bilger <[email protected]>
@VannesteFelix VannesteFelix merged commit 58ec061 into master Oct 17, 2023
6 of 8 checks passed
@VannesteFelix VannesteFelix deleted the fix_python_pipeline branch October 17, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants