Missing calls to super init() #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The init() method usually follows the call super pattern. The components affected by this commit change their behavior.
adagolodjo
approved these changes
Jan 26, 2024
| @@ -72,6 +72,8 @@ DiscreteCosseratMapping<TIn1, TIn2, TOut>::DiscreteCosseratMapping() | |||
| template <class TIn1, class TIn2, class TOut> | |||
| void DiscreteCosseratMapping<TIn1, TIn2, TOut>::init() | |||
| { | |||
| Inherit1::init(); | |||
There was a problem hiding this comment.
@adagolodjo @alxbilger This change makes the scenes crash.
########## SIG 11 - SIGSEGV: segfault ##########
sofa::helper::BackTrace::sig(int)
sofa::component::mapping::BaseCosserat<sofa::defaulttype::StdVectorTypes<sofa::type::Vec<3u, double>, sofa::type::Vec<3u, double>, double>, sofa::defaulttype::StdRigidTypes<3u, double>, sofa::defaulttype::StdRigidTypes<3u, double> >::update_ExponentialSE3(sofa::type::vector<sofa::type::Vec<3u, double>, sofa::type::CPUMemoryManager<sofa::type::Vec<3u, double> > > const&)It seems that the vectors m_indicesVectors, m_framesLengthVectors, and m_BeamLengthVectors are not correctly initialized before the call to update_ExponentialSE3() .
adagolodjo
added a commit
that referenced
this pull request
Dec 7, 2024
Missing calls to super init()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The init() method usually follows the call super pattern. The components affected by this commit change their behavior.
This PR is not as harmless as #96. It must be reviewed with care