Apply new registration mechanism #141
Conversation
|
Please test it on your side before merging: while testing it on my side using the examples, I've had a lots of warning because of multiple registration in the factory. This might be due to multiple loading of the library. Problem is that the example are using some custom headers and so on, I preferred to have your feedback before taking a closer look. |
There was a problem hiding this comment.
Overall, @adagolodjo could you take the opportunity to review all the Component descriptions? I see a lot of copy/paste.
| @@ -35,61 +35,60 @@ | |||
|
|
|||
| //#define SOFTROBOTS_CONSTRAINT_QPSLIDINGCONSTRAINT_NOEXTERN | |||
|
|
|||
| namespace sofa::component::constraintset | |||
| { | |||
| namespace sofa::component::constraintset { | |||
There was a problem hiding this comment.
| namespace sofa::component::constraintset { | |
| namespace sofa::component::constraintset | |
| { |
|
|
||
| //////////////////////////////////////////// FACTORY ////////////////////////////////////////////// | ||
| // Registering the component | ||
| // see: http://wiki.sofa-framework.org/wiki/ObjectFactory | ||
| // 1-RegisterObject("description") + .add<> : Register the component | ||
| // 2-.add<>(true) : Set default template | ||
|
|
||
| int QPSlidingConstraintClass = RegisterObject("Simulate cable actuation.") | ||
| .add< QPSlidingConstraint<sofa::defaulttype::Vec3Types> >(true) | ||
| void registerQPSlidingConstraint(sofa::core::ObjectFactory* factory) |
There was a problem hiding this comment.
the comment just before must be removed. Also in other files
| .add< QPSlidingConstraint<sofa::defaulttype::Vec3Types> >(true) | ||
| void registerQPSlidingConstraint(sofa::core::ObjectFactory* factory) | ||
| { | ||
| factory->registerObjects(sofa::core::ObjectRegistrationData("Simulate cable actuation.") |
There was a problem hiding this comment.
@adagolodjo Can you give a better description? Here, it's copy/paste.
| .add< ProjectionEngine<Vec3Types> >(true); | ||
| void registerProjectionEngine(sofa::core::ObjectFactory *factory) { | ||
| factory->registerObjects( | ||
| sofa::core::ObjectRegistrationData("TODO-ProjectionEngine") |
There was a problem hiding this comment.
@adagolodjo Can you give a better description?
| @@ -32,164 +32,171 @@ | |||
|
|
|||
| #include <sofa/core/ObjectFactory.h> | |||
|
|
|||
| namespace sofa::component::forcefield | |||
| { | |||
| namespace sofa::component::forcefield { | |||
There was a problem hiding this comment.
I don't understand the changes in this files. Why so much changes? Indentation maybe?
| #ifdef COSSERAT_USES_SOFTROBOTS | ||
| extern void registerQPSlidingConstraint(sofa::core::ObjectFactory* factory); | ||
| extern void registerCosseratActuatorConstraint(sofa::core::ObjectFactory* factory); | ||
| #endif |
There was a problem hiding this comment.
this needs to be moved in a Cosserat extension (in a later PR)
| extern void registerCosseratActuatorConstraint(sofa::core::ObjectFactory* factory); | ||
| #endif | ||
|
|
||
| extern void registerCosseratNeedleSlidingConstraint(sofa::core::ObjectFactory* factory); |
This applies the new factory registration mechanism as introduced by [All] ObjectFactory: Explicit components registration #4429
In the process I've encountered a problem of consistency of namespace. I needed all of the registering methods to be in the
Cosseratnamespace. But a lot of SOFA namespace are used. This is bad practice, only the Cosserat namespace should be used in this plugin.