feat: ✨Provided barrier click disable functionality for a particular … #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditya-css
requested changes
Oct 16, 2023
CHANGELOG.md
Outdated
| @@ -1,3 +1,6 @@ | |||
| ## [2.0.4] | |||
There was a problem hiding this comment.
Please mention "unreleased" next to the version.
lib/src/showcase.dart
Outdated
| @@ -244,6 +244,9 @@ class Showcase extends StatefulWidget { | |||
| /// will still provide a callback. | |||
| final VoidCallback? onBarrierClick; | |||
|
|
|||
| /// For disabling barrier interaction for a particular showCase | |||
There was a problem hiding this comment.
Can you please reword the documentation comment ?
lib/src/showcase.dart
Outdated
| "onTargetClick is required if you're using disposeOnTap"); | ||
| "onTargetClick is required if you're using disposeOnTap"), | ||
| assert(onBarrierClick == null || disableBarrierInteraction == false, | ||
| "can't use both property at same time"); |
There was a problem hiding this comment.
please include both properties' names instead of only mentioning "both" in the assert message.
lib/src/showcase.dart
Outdated
| "overlay opacity must be between 0 and 1."); | ||
| "overlay opacity must be between 0 and 1."), | ||
| assert(onBarrierClick == null || disableBarrierInteraction == false, | ||
| "can't use both property at same time"); |
jaiminrana05
force-pushed
the
fix/issue_387_disable_barrier_click
branch
from
926548e to
6446d09
Compare
aditya-css
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…showcase (#387).
Description
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Closes #387