Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click on Barrier close the Showcase with Showcase widget. #407

Closed
FabriceACohen opened this issue Jan 25, 2024 · 1 comment
Closed

Click on Barrier close the Showcase with Showcase widget. #407

FabriceACohen opened this issue Jan 25, 2024 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@FabriceACohen
Copy link

Showcase widget should have a disableBarrierInteraction property as for ShowCaseWidget.

The onTap of the barrier get a the default ShowCaseWidget parameter (false) so if the user click on the barrier the showcase closes since the onTap launch _nextIfAny() that closes the widget.

MoreOther since all this is in the State class that is private no way to overwrite the class...

Would it be possible to add this proposerty and juste change one line of code :
if (!showCaseWidgetState.disableBarrierInteraction) {. WOULD BECOME : if (!widget.disableBarrierInteraction) {

@aditya-css
Copy link
Collaborator

aditya-css commented Feb 6, 2024

Hi @FabriceACohen, please have a look at an already open PR #392 that I believe addresses the same issue that you have mentioned here. Feel free to let me know if that's not the case. Also, there is a similar issue (#387 ) already open.

@aditya-css aditya-css added the duplicate This issue or pull request already exists label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants