Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes issue #417: 🐛 Fixes calendar scroll physics for day & week view #418

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

shubham-jitiya-simform
Copy link
Contributor

Description

  • Updated unused property scrollPhysics in DayView & given scroll physics to SingleChildScrollView in InternalDayViewPage.
  • Added scrollPhysics in week-view & day-view to control the scrolling behaviour.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #417

@shubham-jitiya-simform shubham-jitiya-simform changed the title fix: Fixes issue #417: 🐛 Fixes calendar scroll physics for day & week… fix: Fixes issue #417: 🐛 Fixes calendar scroll physics for day & week view Nov 5, 2024
@shubham-jitiya-simform shubham-jitiya-simform force-pushed the fix/issue_417_scroll_physics branch 2 times, most recently from 0882a33 to e669176 Compare November 5, 2024 07:04
@shubham-jitiya-simform shubham-jitiya-simform marked this pull request as ready for review November 5, 2024 07:09
CHANGELOG.md Outdated Show resolved Hide resolved
@shubham-jitiya-simform shubham-jitiya-simform force-pushed the fix/issue_417_scroll_physics branch from e669176 to f411d41 Compare November 5, 2024 08:14
@shubham-jitiya-simform shubham-jitiya-simform force-pushed the fix/issue_417_scroll_physics branch from f411d41 to 689dac2 Compare November 5, 2024 08:20
Copy link
Collaborator

@PRBaraiya PRBaraiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PRBaraiya PRBaraiya merged commit 372cdcc into master Nov 6, 2024
1 check passed
@PRBaraiya PRBaraiya deleted the fix/issue_417_scroll_physics branch November 6, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ScrollPhysics is not applied for DayView.
2 participants