Merge pull request #418 from SimformSolutionsPvtLtd/fix/issue_417_scr…

…oll_physics fix: Fixes issue #417: 🐛 Fixes calendar scroll physics for day & week view
SimformSolutionsPvtLtd · Nov 6, 2024 · 372cdcc · 372cdcc
2 parents 982747f + 689dac2
commit 372cdcc
Show file tree

Hide file tree

Showing 7 changed files with 19 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,7 @@
     - Added `mainAxisSize`, `mainAxisAlignment`, `rightIconConfig` and `leftIconConfig`.
 - Adds additional configurations for `CalendarPageHeader`, `MonthPageHeader`, `DayPageHeader` and `WeekPageHeader`.
     - Added `titleBuilder` to build custom title for header.
+- Fixes issue calendar scroll physics for day & week view. [#417](https://github.com/SimformSolutionsPvtLtd/flutter_calendar_view/issues/417)
 - `Deprecations`:
     - deprecated `backgroundColor` and `iconColor` from `CalendarPageHeader`, `DayPageHeader`, `MonthPageHeader` and `WeekPageHeader`.
         - **Solution:** use `headerStyle` instead.

diff --git a/example/lib/widgets/day_view_widget.dart b/example/lib/widgets/day_view_widget.dart
@@ -22,6 +22,7 @@ class DayViewWidget extends StatelessWidget {
       showHalfHours: true,
       heightPerMinute: 3,
       timeLineBuilder: _timeLineBuilder,
+      scrollPhysics: const BouncingScrollPhysics(),
       hourIndicatorSettings: HourIndicatorSettings(
         color: Theme.of(context).dividerColor,
       ),

diff --git a/example/lib/widgets/week_view_widget.dart b/example/lib/widgets/week_view_widget.dart
@@ -16,6 +16,7 @@ class WeekViewWidget extends StatelessWidget {
       width: width,
       showLiveTimeLineInAllDays: true,
       timeLineWidth: 65,
+      scrollPhysics: const BouncingScrollPhysics(),
       liveTimeIndicatorSettings: LiveTimeIndicatorSettings(
         color: Colors.redAccent,
         showTime: true,

diff --git a/lib/src/day_view/_internal_day_view_page.dart b/lib/src/day_view/_internal_day_view_page.dart
@@ -133,6 +133,9 @@ class InternalDayViewPage<T extends Object?> extends StatefulWidget {
   /// Flag to keep scrollOffset of pages on page change
   final bool keepScrollOffset;
 
+  /// Use this field to disable the calendar scrolling
+  final ScrollPhysics? scrollPhysics;
+
   /// Defines a single day page.
   const InternalDayViewPage({
     Key? key,
@@ -161,6 +164,7 @@ class InternalDayViewPage<T extends Object?> extends StatefulWidget {
     required this.scrollNotifier,
     required this.fullDayEventBuilder,
     required this.dayViewScrollController,
+    required this.scrollPhysics,
     required this.scrollListener,
     this.lastScrollOffset = 0.0,
     required this.dayDetectorBuilder,
@@ -223,6 +227,7 @@ class _InternalDayViewPageState<T extends Object?>
               controller: widget.keepScrollOffset
                   ? scrollController
                   : widget.dayViewScrollController,
+              physics: widget.scrollPhysics,
               child: SizedBox(
                 height: widget.height,
                 width: widget.width,

diff --git a/lib/src/day_view/day_view.dart b/lib/src/day_view/day_view.dart
@@ -497,6 +497,7 @@ class DayViewState<T extends Object?> extends State<DayView<T>> {
                                 widget.emulateVerticalOffsetBy,
                             lastScrollOffset: _lastScrollOffset,
                             dayViewScrollController: _scrollController,
+                            scrollPhysics: widget.scrollPhysics,
                             scrollListener: _scrollPageListener,
                             keepScrollOffset: widget.keepScrollOffset,
                           ),

diff --git a/lib/src/week_view/_internal_week_view_page.dart b/lib/src/week_view/_internal_week_view_page.dart
@@ -160,6 +160,9 @@ class InternalWeekViewPage<T extends Object?> extends StatefulWidget {
   /// Flag to keep scrollOffset of pages on page change
   final bool keepScrollOffset;
 
+  /// Use this field to disable the calendar scrolling
+  final ScrollPhysics? scrollPhysics;
+
   /// A single page for week view.
   const InternalWeekViewPage({
     Key? key,
@@ -204,6 +207,7 @@ class InternalWeekViewPage<T extends Object?> extends StatefulWidget {
     required this.endHour,
     this.fullDayHeaderTitle = '',
     required this.fullDayHeaderTextConfig,
+    required this.scrollPhysics,
     required this.scrollListener,
     required this.weekViewScrollController,
     this.lastScrollOffset = 0.0,
@@ -339,6 +343,7 @@ class _InternalWeekViewPageState<T extends Object?>
               controller: widget.keepScrollOffset
                   ? scrollController
                   : widget.weekViewScrollController,
+              physics: widget.scrollPhysics,
               child: SizedBox(
                 height: widget.height,
                 width: widget.width,

diff --git a/lib/src/week_view/week_view.dart b/lib/src/week_view/week_view.dart
@@ -230,6 +230,9 @@ class WeekView<T extends Object?> extends StatefulWidget {
   /// If true this will show week day at bottom position.
   final bool showWeekDayAtBottom;
 
+  /// Use this field to disable the calendar scrolling
+  final ScrollPhysics? scrollPhysics;
+
   /// Defines scroll physics for a page of a week view.
   ///
   /// This can be used to disable the horizontal scroll of a page.
@@ -273,6 +276,7 @@ class WeekView<T extends Object?> extends StatefulWidget {
     this.weekDayBuilder,
     this.weekNumberBuilder,
     this.backgroundColor = Colors.white,
+    this.scrollPhysics,
     this.scrollOffset = 0.0,
     this.onEventTap,
     this.onEventLongTap,
@@ -561,6 +565,7 @@ class WeekViewState<T extends Object?> extends State<WeekView<T>> {
                             fullDayHeaderTitle: _fullDayHeaderTitle,
                             fullDayHeaderTextConfig: _fullDayHeaderTextConfig,
                             lastScrollOffset: _lastScrollOffset,
+                            scrollPhysics: widget.scrollPhysics,
                             scrollListener: _scrollPageListener,
                             keepScrollOffset: widget.keepScrollOffset,
                           ),