[BACKPORT] vtgate: fix race condition iterating tables and views from schema tracker #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austenLacy
force-pushed
the
austenlacy/backport-vtgate-schema-change-race-condition
branch
from
81609ae to
13d45b4
Compare
austenLacy
commented
Aug 16, 2023
| @@ -118,6 +118,7 @@ require ( | |||
| require ( | |||
| github.com/bndr/gotabulate v1.1.2 | |||
| github.com/hashicorp/go-version v1.6.0 | |||
| golang.org/x/exp v0.0.0-20230811145659-89c5cff77bcb | |||
There was a problem hiding this comment.
Had to add this to for the package used upstream. It also required some version bumps of other libs so we could use the version that doesn't use maps.Clone() since the golang.org/x/exp lib is pretty new.
Thoughts @brendar?
There was a problem hiding this comment.
Seems fine, but TBH I'm not familiar enough with Go to know the risk of minor version bumps in those packages
BoGs
approved these changes
Aug 16, 2023
brendar
approved these changes
Aug 16, 2023
|
@austenLacy I think you'll need to change the base branch for this PR to |
austenLacy
changed the base branch from
v15.0.3-shopify-4
to
v15.0.3-shopify-5
austenLacy
deleted the
austenlacy/backport-vtgate-schema-change-race-condition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Back ports upstream vitessio#13673. The upstream included some extra handling for views in the vtgate schema tracker, but v15 doesn't have logic so it's excluded here.
Related Issue(s)
Checklist
Deployment Notes