hide navigation bar when web modals are displayed #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiftio
changed the title
kiftio
changed the title
|
For some reason I can't see the videos you posted 🙃 But I'd love to see what you were able to do and finesse it! |
markmur
reviewed
Oct 20, 2023
Comment on lines
155
to
156
| func checkoutViewDidToggleModal() { | ||
| if blurVisualEffect.superview == nil { | ||
| let bounds = self.navigationController?.navigationBar.bounds | ||
| blurVisualEffect.frame = bounds ?? CGRect.zero | ||
| blurVisualEffect.autoresizingMask = [.flexibleWidth, .flexibleHeight] | ||
| self.navigationController?.navigationBar.addSubview(blurVisualEffect) | ||
| } else { | ||
| blurVisualEffect.removeFromSuperview() | ||
| } | ||
| } |
There was a problem hiding this comment.
I think we'll have to account for the transition time here
It seems like we lost access to the assets we'd uploaded to GitHub when we made the repo public. I've re-uploaded, and also changed the approach a bit to hide the header instead of blurring it. |
kiftio
changed the title
…web modals are shown
kiftio
force-pushed
the
dk/listen-for-checkout-blocking-event
branch
from
261a85e to
faeda12
Compare
markmur
approved these changes
Oct 27, 2023
kiftio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Listen to checkoutBlockingEvents sent from web, and blur the navigation bar, so that we can avoid double headers / close buttons.
I'm very open to better options for the blur effect
Video
updated.mp4
Example of Current Header
Before you deploy