parse visible property from event and use that to hide/show nav bar

Shopify · Oct 20, 2023 · 261a85e · 261a85e
1 parent 30b0082
commit 261a85e
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 10 deletions.
diff --git a/Sources/ShopifyCheckout/CheckoutBridge.swift b/Sources/ShopifyCheckout/CheckoutBridge.swift
@@ -58,7 +58,7 @@ extension CheckoutBridge {
 		case checkoutCanceled
 		case checkoutExpired
 		case checkoutUnavailable
-		case checkoutModalToggled
+		case checkoutModalToggled(modalVisible: Bool)
 		case unsupported(String)
 
 		enum CodingKeys: String, CodingKey {
@@ -80,7 +80,8 @@ extension CheckoutBridge {
 				// needs to support .checkoutUnavailable by parsing error payload on body
 				self = .checkoutExpired
 			case "checkoutBlockingEvent":
-				self = .checkoutModalToggled
+				let modalVisible = try container.decode(String.self, forKey: .body)
+				self = .checkoutModalToggled(modalVisible: Bool(modalVisible)!)
 			default:
 				self = .unsupported(name)
 			}

diff --git a/Sources/ShopifyCheckout/CheckoutView.swift b/Sources/ShopifyCheckout/CheckoutView.swift
@@ -30,7 +30,7 @@ protocol CheckoutViewDelegate: AnyObject {
 	func checkoutViewDidFinishNavigation()
 	func checkoutViewDidClickLink(url: URL)
 	func checkoutViewDidFailWithError(error: CheckoutError)
-	func checkoutViewDidToggleModal()
+	func checkoutViewDidToggleModal(modalVisible: Bool)
 }
 
 class CheckoutView: WKWebView {
@@ -105,8 +105,8 @@ extension CheckoutView: WKScriptMessageHandler {
 			case .checkoutUnavailable:
 				CheckoutView.cache = nil
 				viewDelegate?.checkoutViewDidFailWithError(error: .checkoutUnavailable(message: "Checkout unavailable."))
-			case .checkoutModalToggled:
-				viewDelegate?.checkoutViewDidToggleModal()
+			case let .checkoutModalToggled(modalVisible):
+				viewDelegate?.checkoutViewDidToggleModal(modalVisible: modalVisible)
 			default:
 				()
 			}

diff --git a/Sources/ShopifyCheckout/CheckoutViewController.swift b/Sources/ShopifyCheckout/CheckoutViewController.swift
@@ -150,8 +150,8 @@ extension CheckoutViewController: CheckoutViewDelegate {
 		delegate?.checkoutDidClickLink(url: url)
 	}
 
-	func checkoutViewDidToggleModal() {
-		let hide = !self.navigationController!.isNavigationBarHidden
-		self.navigationController?.setNavigationBarHidden(hide, animated: true)
+	func checkoutViewDidToggleModal(modalVisible: Bool) {
+		guard let navigationController = self.navigationController else { return }
+		navigationController.setNavigationBarHidden(modalVisible, animated: true)
 	}
 }
diff --git a/Tests/ShopifyCheckoutTests/CheckoutViewControllerTests.swift b/Tests/ShopifyCheckoutTests/CheckoutViewControllerTests.swift
@@ -104,10 +104,10 @@ class CheckoutViewDelegateTests: XCTestCase {
 	func testCheckoutViewDidToggleModalAddsAndRemovesNavigationBar() {
 		XCTAssertFalse(viewController.navigationController!.isNavigationBarHidden)
 
-		viewController.checkoutViewDidToggleModal()
+		viewController.checkoutViewDidToggleModal(modalVisible: true)
 		XCTAssertTrue(viewController.navigationController!.isNavigationBarHidden)
 
-		viewController.checkoutViewDidToggleModal()
+		viewController.checkoutViewDidToggleModal(modalVisible: false)
 		XCTAssertFalse(viewController.navigationController!.isNavigationBarHidden)
 	}
 }