Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Test #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Feature Test #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions example_scenes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
from manimlib import *
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an opensource library?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs improvement - better integration

Sema Reaction: ❓ I have a question | Sema Tags: Inefficient

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smoke 1/31/2022

__
sema-logo  Summary: 👌 This code looks good

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

automation test data
A best practice is to always define default timezone of your application in config/application.rb.

Date.today and Time.now always gives the local date and time of the machine, in the machine’s timezone. It makes sense to use Time.zone.now and Time.zone.today to get around the conflicts between timezones on development machines and production servers.

Sema Reaction: 🛠️ This code needs a fix | Sema Tags: Readable, Secure, Brittle, Maintainable

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

__
sema-logo  Tags: Efficient

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test1

import numpy as np

# how can we improve the feature set?
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we import pandas for table manipulation?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs fix - not maintainable

Sema Reaction: 🛠️ This code needs a fix | Sema Tags: Not maintainable

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent - good job

Sema Reaction: 🛠️ This code needs a fix

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The software constructs all or part of an SQL command using externally-influenced input from an upstream component, but it does not neutralize or incorrectly neutralizes special elements that could modify the intended SQL command when it is sent to a downstream component.
The software contains a data query against an SQL table or view that is configured in a way that does not utilize an index and may cause sequential searches to be performed.

Sema Reaction: 🛠️ This code needs a fix

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code performs a comparison such as an equality test between two float (floating point) values, but it uses comparison operators that do not account for the possibility of loss of precision.

📄 Mitre

__
sema-logo  Summary: 🛠️ This code needs a fix

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

123


# To watch one of these scenes, run the following:
# manimgl example_scenes.py OpeningManimExample
# Use -s to skip to the end and just save the final frame
Expand Down