Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Test #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Feature Test #6

wants to merge 1 commit into from

Conversation

paramnayar
Copy link

Motivation

Proposed changes

Test

Code:

Result:

Copy link
Author

@paramnayar paramnayar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questions about the code and possible imporvements

@@ -1,6 +1,8 @@
from manimlib import *
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an opensource library?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs improvement - better integration


Sema Reaction: ❓ I have a question | Sema Tags: Inefficient

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smoke 1/31/2022

__
sema-logo  Summary: 👌 This code looks good

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

automation test data
A best practice is to always define default timezone of your application in config/application.rb.

Date.today and Time.now always gives the local date and time of the machine, in the machine’s timezone. It makes sense to use Time.zone.now and Time.zone.today to get around the conflicts between timezones on development machines and production servers.


Sema Reaction: 🛠️ This code needs a fix | Sema Tags: Readable, Secure, Brittle, Maintainable

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

__
sema-logo  Tags: Efficient

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test1

@@ -1,6 +1,8 @@
from manimlib import *
import numpy as np

# how can we improve the feature set?
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we import pandas for table manipulation?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs fix - not maintainable


Sema Reaction: 🛠️ This code needs a fix | Sema Tags: Not maintainable

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent - good job


Sema Reaction: 🛠️ This code needs a fix

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The software constructs all or part of an SQL command using externally-influenced input from an upstream component, but it does not neutralize or incorrectly neutralizes special elements that could modify the intended SQL command when it is sent to a downstream component.
The software contains a data query against an SQL table or view that is configured in a way that does not utilize an index and may cause sequential searches to be performed.


Sema Reaction: 🛠️ This code needs a fix

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code performs a comparison such as an equality test between two float (floating point) values, but it uses comparison operators that do not account for the possibility of loss of precision.

📄 Mitre

__
sema-logo  Summary: 🛠️ This code needs a fix

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

123

@semaonb
Copy link

semaonb commented Jan 13, 2022

The code performs a comparison such as an equality test between two float (floating point) values, but it uses comparison operators that do not account for the possibility of loss of precision.

📄 Mitre

__
sema-logo  Summary: 🛠️ This code needs a fix

@ghost
Copy link

ghost commented Feb 2, 2022

The storage of passwords in a recoverable format makes them subject to password reuse attacks by malicious users. In fact, it should be noted that recoverable encrypted passwords provide no significant benefi...

📄 Mitre

__
sema-logo  Summary: 🛠️ This code needs a fix

@ghost
Copy link

ghost commented Feb 2, 2022

The software constructs all or part of an OS command using externally-influenced input from an upstream component, but it does not neutralize or incorrectly neutralizes special elements that could modify the intended OS command when it is sent to a downstream component.

📄 Mitre

__
sema-logo  Summary: 🛠️ This code needs a fix  |  Tags: Readable, Secure, Efficient

@ghost
Copy link

ghost commented Apr 5, 2022

123

📄 123

__
sema-logo  Summary: 🛠️ This code needs a fix  |  Tags: Unreadable, Not secure, Inefficient, Inelegant

@ghost
Copy link

ghost commented Apr 15, 2022

segment test 4/15

@Rusau
Copy link

Rusau commented Apr 19, 2022

test 4/19/2022

__
sema-logo  Summary: 🏆 This code is awesome  |  Tags: Efficient, Not reusable, Maintainable

@yanakovrygina
Copy link

It’s strongly recommended to always check the db/schema.rb file into your version control system. If this file is not checked in and not up to date, then you can’t utilize rails db:schema:load. If you need to...

📄 Sitepoint

__
sema-logo  Summary: 🛠️ This code needs a fix

@joiesemagituser05
Copy link

(test)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants