-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tensorflow requirement from !=2.6.0,!=2.6.1,<2.15.0,>=2.0.0 to >=2.0.0,!=2.6.0,!=2.6.1,<2.19.0 #1023
Changes from 29 commits
4000b36
39adc9f
5ec4b7b
ba44c42
cc47fc5
b3641a8
9eeb657
eee40d5
5a1f10c
b17b03e
3e17adf
4af6c22
ca0dd4d
138c212
1db3f74
8623ecc
a916ec7
9c0007e
48f2fab
791f7af
93e81e1
64beec2
1f3bdc9
8f86bd2
ea0f2cb
77a0a46
a39d198
f9db0d3
f715c9d
9d4088e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,7 +35,7 @@ jobs: | |
strategy: | ||
matrix: | ||
os: [ ubuntu-latest ] | ||
python-version: [ '3.8', '3.9', '3.10', '3.11'] | ||
python-version: ['3.9', '3.10', '3.11'] | ||
include: # Run windows tests on only one python version | ||
- os: windows-latest | ||
python-version: '3.11' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. set at least to 3.12? |
||
|
@@ -68,9 +68,7 @@ jobs: | |
limit-access-to-actor: true | ||
|
||
- name: Test with pytest | ||
run: | | ||
pytest -m tf1 alibi | ||
pytest -m "not tf1" alibi | ||
run: make test | ||
|
||
- name: Upload coverage to Codecov | ||
uses: codecov/codecov-action@v4 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
import pytest | ||
from pytest_lazyfixture import lazy_fixture | ||
import torch | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why is torch required? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is used by one of the fixtures. |
||
import numpy as np | ||
import tensorflow as tf | ||
import torch | ||
|
||
from alibi.api.defaults import DEFAULT_META_ANCHOR, DEFAULT_DATA_ANCHOR_IMG | ||
from alibi.exceptions import PredictorCallError, PredictorReturnTypeError | ||
|
@@ -44,7 +44,7 @@ def func(image: np.ndarray) -> np.ndarray: | |
|
||
@pytest.mark.parametrize('predict_fn', [lazy_fixture('models'), ], indirect=True) | ||
@pytest.mark.parametrize('models', | ||
[("mnist-cnn-tf2.2.0",), ("mnist-cnn-tf1.15.2.h5",), ("mnist-cnn-pt1.9.1.pt",)], | ||
[("mnist-cnn-tf2.18.0.keras",), ("mnist-cnn-pt1.9.1.pt",)], | ||
indirect=True, | ||
ids='models={}'.format | ||
) | ||
|
@@ -99,7 +99,7 @@ def test_sampler(predict_fn, models, mnist_data): | |
|
||
@pytest.mark.parametrize('predict_fn', [lazy_fixture('models'), ], indirect=True) | ||
@pytest.mark.parametrize('models', | ||
[("mnist-cnn-tf2.2.0",), ("mnist-cnn-tf1.15.2.h5",), ("mnist-cnn-pt1.9.1.pt",)], | ||
[("mnist-cnn-tf2.18.0.keras",), ("mnist-cnn-pt1.9.1.pt",)], | ||
indirect=True, | ||
ids='models={}'.format | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add also 3.12 (and potentially 3.13)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am planning to do other PRs to completely remove 3.8 and another one to add 3.12