-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tensorflow requirement from !=2.6.0,!=2.6.1,<2.15.0,>=2.0.0 to >=2.0.0,!=2.6.0,!=2.6.1,<2.19.0 #1023
Conversation
Updates the requirements on [tensorflow](https://github.com/tensorflow/tensorflow) to permit the latest version. - [Release notes](https://github.com/tensorflow/tensorflow/releases) - [Changelog](https://github.com/tensorflow/tensorflow/blob/master/RELEASE.md) - [Commits](tensorflow/tensorflow@v2.0.0...v2.18.0) --- updated-dependencies: - dependency-name: tensorflow dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
Dependabot tried to add
|
|
This reverts commit b3641a8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -35,7 +35,7 @@ jobs: | |||
strategy: | |||
matrix: | |||
os: [ ubuntu-latest ] | |||
python-version: [ '3.8', '3.9', '3.10', '3.11'] | |||
python-version: ['3.9', '3.10', '3.11'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add also 3.12 (and potentially 3.13)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am planning to do other PRs to completely remove 3.8 and another one to add 3.12
@@ -35,7 +35,7 @@ jobs: | |||
strategy: | |||
matrix: | |||
os: [ ubuntu-latest ] | |||
python-version: [ '3.8', '3.9', '3.10', '3.11'] | |||
python-version: ['3.9', '3.10', '3.11'] | |||
include: # Run windows tests on only one python version | |||
- os: windows-latest | |||
python-version: '3.11' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set at least to 3.12?
@@ -1,8 +1,8 @@ | |||
import pytest | |||
from pytest_lazyfixture import lazy_fixture | |||
import torch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is torch required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is used by one of the fixtures.
setup.py
Outdated
# `keras 3` becomes the default for `tensorflow >= 2.16.0`` | ||
# which is not yet supported by `transformers` | ||
'tensorflow': [ | ||
'tensorflow>=2.0.0, !=2.6.0, !=2.6.1, <2.19.0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should the min version for tf be 2.16.0 now?
setup.py
Outdated
@@ -17,14 +17,20 @@ def readme(): | |||
'numba>=0.50.0, !=0.54.0, <0.60.0', # Avoid 0.54 due to: https://github.com/SeldonIO/alibi/issues/466 | |||
], | |||
|
|||
'tensorflow': ['tensorflow>=2.0.0, !=2.6.0, !=2.6.1, <2.15.0'], | |||
# `keras 3` becomes the default for `tensorflow >= 2.16.0`` | |||
# which is not yet supported by `transformers` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update comment as I am not sure how it relates to the version you are setting for example for tf_keras.
Updates the requirements on tensorflow to permit the latest version.
Release notes
Sourced from tensorflow's releases.
Changelog
Sourced from tensorflow's changelog.
... (truncated)
Commits
6550e4b
Merge pull request #78464 from tensorflow/rtg0795-patch-17e0c244
Merge pull request #78463 from tensorflow-jenkins/version-numbers-2.18.0-2110135624d2
Update RELEASE.md to move TFLite SignatureRunner to the right section8d2c5e1
Update version numbers to 2.18.0d5f4a3f
Merge pull request #77589 from tensorflow-jenkins/version-numbers-2.18.0rc2-1...7cbcbf3
Update version numbers to 2.18.0-rc284c9398
Merge pull request #77576 from tensorflow/r2.18-be4f646ec438fca5e7
PR #17430: [ROCm] Use unique_ptr for TupleHandle in pjrt_se_client2c3c798
Merge pull request #77025 from tensorflow-jenkins/version-numbers-2.18.0rc1-2...10693a4
Update version numbers to 2.18.0-rc1Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)