Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integer optimization #6

Merged
merged 9 commits into from
Jun 6, 2023
Merged

Integer optimization #6

merged 9 commits into from
Jun 6, 2023

Conversation

alexkeating
Copy link
Collaborator

@alexkeating alexkeating commented May 31, 2023 •
edited
Loading

Description

  • Make uint256 a uint96 to save calldata
  • Why we can't optimize flags
  • Remove padding by using encodePacked

Closes #7

@alexkeating alexkeating force-pushed the feature/uint96-optimization branch from 4d5231c to e449fc4 Compare June 1, 2023 01:07
@alexkeating alexkeating requested a review from mds1 June 1, 2023 01:09
@alexkeating alexkeating marked this pull request as ready for review June 1, 2023 01:09
mds1
mds1 reviewed Jun 1, 2023
View reviewed changes
src/V4Router.sol Outdated Show resolved Hide resolved
src/V5Router.sol Outdated Show resolved Hide resolved
test/V4Router.t.sol Outdated Show resolved Hide resolved
test/V4Router.t.sol Outdated Show resolved Hide resolved
test/V4Router.t.sol Outdated Show resolved Hide resolved
test/V5Router.t.sol Outdated Show resolved Hide resolved
script/Benchmark.s.sol Outdated Show resolved Hide resolved
@alexkeating alexkeating force-pushed the feature/uint96-optimization branch from 585391f to e7357d2 Compare June 5, 2023 14:26
@alexkeating alexkeating force-pushed the feature/uint96-optimization branch from e7357d2 to 9cc4b35 Compare June 5, 2023 14:27
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Coverage after merging feature/uint96-optimization into main will be

90.63%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   RouterFactory.sol86.67%75%100%88.24%59, 68, 77, 84
   V4Router.sol100%100%100%100%
   V5Router.sol100%100%100%100%
src/lib
   Create2.sol0%100%0%0%11

@mds1 mds1 merged commit 6dad24f into main Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mds1 mds1 mds1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize uint256
2 participants
@alexkeating @mds1