Remove another unnecessary casting

ScopeLift · Jun 5, 2023 · 9cc4b35 · 9cc4b35
1 parent 006e854
commit 9cc4b35
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/script/Benchmark.s.sol b/script/Benchmark.s.sol
@@ -61,9 +61,7 @@ contract Benchmark is Script, OneInchContracts {
 
     // Optimized router v5 swap call
     (bool v5Ok,) = payable(v5Rtr).call(
-      abi.encodePacked(
-        DAI, uint96(100_000), uint96(v5Desc.minReturnAmount), uint256(0), bytes(v5Data)
-      )
+      abi.encodePacked(DAI, uint96(100_000), uint96(v5Desc.minReturnAmount), uint256(0), v5Data)
     );
 
     if (!v5Ok) revert OptimizedV5RouterFailed();
@@ -83,9 +81,7 @@ contract Benchmark is Script, OneInchContracts {
 
     // Optimized v4 swap call
     (bool v4Ok,) = payable(v4Rtr).call(
-      abi.encodePacked(
-        DAI, uint96(100_000), uint96(v4Desc.minReturnAmount), uint256(0), bytes(v4Data)
-      )
+      abi.encodePacked(DAI, uint96(100_000), uint96(v4Desc.minReturnAmount), uint256(0), v4Data)
     );
     if (!v4Ok) revert OptimizedV4RouterFailed();
   }

diff --git a/test/V4Router.t.sol b/test/V4Router.t.sol
@@ -146,9 +146,7 @@ contract Fallback is V4RouterTest {
     IERC20(USDC).approve(routerAddr, 250_000);
     uint256 startingBalance = IERC20(USDC).balanceOf(swapSenderAddress);
     (bool ok,) = payable(routerAddr).call(
-      abi.encodePacked(
-        address(0), uint96(250_000), uint96(desc.minReturnAmount), uint256(0), bytes(data)
-      )
+      abi.encodePacked(address(0), uint96(250_000), uint96(desc.minReturnAmount), uint256(0), data)
     );
     uint256 endingBalance = IERC20(USDC).balanceOf(swapSenderAddress);