Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ENS names #159

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Support ENS names #159

merged 2 commits into from
Dec 4, 2023

Conversation

alexkeating
Copy link
Collaborator

@alexkeating alexkeating commented Nov 28, 2023

Description

  • Rainbow shows ENS
  • Input works with ENS address
  • Delegate shows ENS address and avatar

Closes #160

@alexkeating
Copy link
Collaborator Author

@alexkeating alexkeating force-pushed the feature/support-more-statuses branch from 9696c60 to 2972c88 Compare November 28, 2023 19:57
@alexkeating alexkeating force-pushed the feature/support-ens-names branch 2 times, most recently from ba6ace0 to ee4b29c Compare November 28, 2023 20:14
@alexkeating alexkeating changed the base branch from feature/support-more-statuses to main November 29, 2023 22:03
@alexkeating alexkeating force-pushed the feature/support-ens-names branch from ee4b29c to 392b335 Compare November 29, 2023 22:03
Copy link

netlify bot commented Nov 29, 2023

Deploy Preview for l2-flexible-voting ready!

Name Link
🔨 Latest commit 4fa7d4f
🔍 Latest deploy log https://app.netlify.com/sites/l2-flexible-voting/deploys/656dfe1eeae4d70008261d1c
😎 Deploy Preview https://deploy-preview-159--l2-flexible-voting.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alexkeating alexkeating marked this pull request as ready for review November 29, 2023 22:06
Copy link
Member

@garyghayrat garyghayrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working great! thanks!


export const chains = [goerli, optimismGoerli];
export const chains = [goerli, optimismGoerli, mainnet];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-12-01 at 4 38 35 PM

this adds mainnet to the chains dropdown; i played around locally to see if we can avoid this, and i came to the same conclusion that you did: seems unavoidable!

@alexkeating alexkeating force-pushed the feature/support-ens-names branch from 392b335 to b4cae0c Compare December 4, 2023 16:19
@alexkeating alexkeating force-pushed the feature/support-ens-names branch from b4cae0c to 4b9d708 Compare December 4, 2023 16:27
@alexkeating alexkeating merged commit 640e70e into main Dec 4, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ENS names
3 participants