Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messaging #157

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Improve error messaging #157

merged 3 commits into from
Nov 28, 2023
+57 −35

Conversation

alexkeating
Copy link
Collaborator

@alexkeating alexkeating commented Nov 28, 2023 •
edited
Loading

Description

  • Convert input to react-hook-form validation
  • Check if negative number
  • Check if input is a number
  • Make error box overflow on auto

Closes #151

This was referenced Nov 28, 2023
Merged
Merged
@alexkeating
Copy link
Collaborator Author

alexkeating commented Nov 28, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@alexkeating alexkeating marked this pull request as ready for review November 28, 2023 13:59
This was referenced Nov 28, 2023
Merged
Merged
wildmolasses
wildmolasses approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@wildmolasses wildmolasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me; a few nits to consider, otherwise good to merge

config.ts Outdated Show resolved Hide resolved
pages/[id]/bridge.tsx Outdated Show resolved Hide resolved
pages/[id]/bridge.tsx Outdated Show resolved Hide resolved
pages/[id]/bridge.tsx Outdated Show resolved Hide resolved
pages/[id]/bridge.tsx Show resolved Hide resolved
pages/[id]/bridge.tsx Show resolved Hide resolved
@alexkeating alexkeating force-pushed the feature/support-more-statuses branch from 9696c60 to 2972c88 Compare November 28, 2023 19:57
@alexkeating alexkeating force-pushed the chore/cleanup-the-error branch 2 times, most recently from 114a25e to 8fe031d Compare November 28, 2023 20:14
@alexkeating alexkeating changed the base branch from feature/support-more-statuses to main November 28, 2023 20:52
@alexkeating alexkeating force-pushed the chore/cleanup-the-error branch from 8fe031d to 283e41d Compare November 28, 2023 20:52
@netlify Netlify
Copy link

netlify bot commented Nov 28, 2023 •
edited
Loading

✅ Deploy Preview for l2-flexible-voting ready!

Name Link
🔨 Latest commit 283e41d
🔍 Latest deploy log https://app.netlify.com/sites/l2-flexible-voting/deploys/65665314227ca70008dc73a4
😎 Deploy Preview https://deploy-preview-157--l2-flexible-voting.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alexkeating alexkeating merged commit d7c3784 into main Nov 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wildmolasses wildmolasses wildmolasses approved these changes

@garyghayrat garyghayrat Awaiting requested review from garyghayrat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve bridge error handling
2 participants
@alexkeating @wildmolasses