Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CubicSplines: Add AbstractMatrix support #343

Merged
merged 8 commits into from
Oct 14, 2024
Merged

CubicSplines: Add AbstractMatrix support #343

merged 8 commits into from
Oct 14, 2024

Conversation

ashutosh-b-b
Copy link
Contributor

@ashutosh-b-b ashutosh-b-b commented Oct 7, 2024 •
edited
Loading

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@ChrisRackauckas
Copy link
Member

Why is this needed instead of the vector of vector form?

@sathvikbhagavan
Copy link
Member

I think we should have both forms. Its also part of fixing #206

@ashutosh-b-b
Copy link
Contributor Author

Why is this needed instead of the vector of vector form?

We can extend this to higher dimensional matrix. That is of course dependent on, whether we need that in DataInterpolations.jl

@ChrisRackauckas
Copy link
Member

I see, yes we should support fully then.

@ashutosh-b-b
Copy link
Contributor Author

Generalized this to AbstractArray and added tests for 3d arrays as well.

@sathvikbhagavan
Copy link
Member

Can you rebase on master?

@ashutosh-b-b ashutosh-b-b marked this pull request as ready for review October 14, 2024 03:34
sathvikbhagavan
sathvikbhagavan approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@sathvikbhagavan sathvikbhagavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A rebase and should be good to merge!

@ChrisRackauckas ChrisRackauckas merged commit d7dab66 into SciML:master Oct 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sathvikbhagavan sathvikbhagavan sathvikbhagavan approved these changes

@ChrisRackauckas ChrisRackauckas ChrisRackauckas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashutosh-b-b @ChrisRackauckas @sathvikbhagavan