Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nailgun.entities imports in tests/foreman/endtoend #15083

Merged
merged 1 commit into from
May 16, 2024
Merged

Remove nailgun.entities imports in tests/foreman/endtoend #15083

merged 1 commit into from
May 16, 2024

Conversation

tpapaioa
Copy link
Contributor

@tpapaioa tpapaioa commented May 16, 2024 •
edited
Loading

Problem Statement

SAT-22502

Uses of nailgun.entities.${ENTITY} should be replaced with ${SATELLITE_INSTANCE}.api.${ENTITY}.

Solution

All tests under tests/foreman/endtoend/ now use nailgun through the satellite instance's api attribute, and imports of nailgun.entities have been removed.

@tpapaioa tpapaioa added 6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches labels May 16, 2024
@tpapaioa
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/endtoend/test_api_endtoend.py -k 'test_positive_find_default_org or test_positive_find_default_loc or test_positive_find_admin_user'

@tpapaioa tpapaioa force-pushed the endtoend_tests_remove_entities_module branch from e3548ef to 7e86af2 Compare May 16, 2024 14:36
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6962
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/endtoend/test_api_endtoend.py -k test_positive_find_default_org or test_positive_find_default_loc or test_positive_find_admin_user --external-logging
Test Result : =========== 3 passed, 3 deselected, 35 warnings in 671.16s (0:11:11) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 16, 2024
@tpapaioa tpapaioa marked this pull request as ready for review May 16, 2024 14:54
@tpapaioa tpapaioa requested a review from a team as a code owner May 16, 2024 14:54
@Gauravtalreja1 Gauravtalreja1 added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label May 16, 2024
@Gauravtalreja1 Gauravtalreja1 merged commit e5a10ee into SatelliteQE:master May 16, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request May 16, 2024
@tpapaioa @web-flow
Remove nailgun.entities imports in tests/foreman/endtoend (#15083)
5d20d18 
(cherry picked from commit e5a10ee)
@Satellite-QE Satellite-QE mentioned this pull request May 16, 2024
Merged
github-actions bot pushed a commit that referenced this pull request May 16, 2024
@tpapaioa @web-flow
Remove nailgun.entities imports in tests/foreman/endtoend (#15083)
4328b29 
(cherry picked from commit e5a10ee)
@Satellite-QE Satellite-QE mentioned this pull request May 16, 2024
Merged
github-actions bot pushed a commit that referenced this pull request May 16, 2024
@tpapaioa @web-flow
Remove nailgun.entities imports in tests/foreman/endtoend (#15083)
a285a90 
(cherry picked from commit e5a10ee)
@Satellite-QE Satellite-QE mentioned this pull request May 16, 2024
Merged
github-actions bot pushed a commit that referenced this pull request May 16, 2024
@tpapaioa @web-flow
Remove nailgun.entities imports in tests/foreman/endtoend (#15083)
5be3d37 
(cherry picked from commit e5a10ee)
@Satellite-QE Satellite-QE mentioned this pull request May 16, 2024
Merged
@tpapaioa tpapaioa deleted the endtoend_tests_remove_entities_module branch May 16, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

Assignees

@tpapaioa tpapaioa

Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tpapaioa @Satellite-QE @Gauravtalreja1