Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.13.z] Remove nailgun.entities imports in tests/foreman/endtoend #15087

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #15083

Problem Statement

SAT-22502

Uses of nailgun.entities.${ENTITY} should be replaced with ${SATELLITE_INSTANCE}.api.${ENTITY}.

Solution

All tests under tests/foreman/endtoend/ now use nailgun through the satellite instance's api attribute, and imports of nailgun.entities have been removed.

@Satellite-QE Satellite-QE added 6.13.z Introduced in or relating directly to Satellite 6.13 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels May 16, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/endtoend/test_api_endtoend.py -k 'test_positive_find_default_org or test_positive_find_default_loc or test_positive_find_admin_user'

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label May 16, 2024
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 6966
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/endtoend/test_api_endtoend.py -k test_positive_find_default_org or test_positive_find_default_loc or test_positive_find_admin_user --external-logging
Test Result : ========== 3 passed, 3 deselected, 35 warnings in 1098.69s (0:18:18) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 16, 2024
@Satellite-QE Satellite-QE merged commit 292e188 into 6.13.z May 16, 2024
17 of 18 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.13.z-e5a10ee46d01ea3b343e6a48a32561a9dcd8200f branch May 16, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z Introduced in or relating directly to Satellite 6.13 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants