Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CV Eval] CV Version Test #14949

Merged
merged 12 commits into from
Jun 3, 2024
Merged

[CV Eval] CV Version Test #14949

merged 12 commits into from
Jun 3, 2024

Conversation

sambible
Copy link
Contributor

@sambible sambible commented May 3, 2024

Test for CV Version table, as well as for this CC BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1911545
(Reopening of an older PR)

Requires: SatelliteQE/airgun#1083

@sambible sambible added CherryPick PR needs CherryPick to previous branches 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels May 3, 2024
@sambible sambible self-assigned this May 3, 2024
@sambible sambible requested a review from a team as a code owner May 3, 2024 15:09
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6788
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_contentview.py -k test_version_table_read --external-logging
Test Result : ========== 1 failed, 2 deselected, 16 warnings in 1073.05s (0:17:53) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label May 3, 2024
@sambible
Copy link
Contributor Author

sambible commented May 3, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_contentview.py -k test_version_table_read
airgun: 1083

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6792
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_contentview.py -k test_version_table_read --external-logging
Test Result : ========== 1 failed, 2 deselected, 16 warnings in 1149.65s (0:19:09) ===========

shweta83
shweta83 requested changes May 7, 2024
View reviewed changes
tests/foreman/ui/test_contentview.py Outdated
)
assert package_name in response[0]['Name']
assert response[0]['Epoch']
assert response[0]['Name'] == 'aajohan-comfortaa-fonts-3.001-2.el8.noarch'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test will fail on RHEL9 Satellite.

tests/foreman/ui/test_contentview.py Outdated
)
assert package_name in response[0]['Name']
assert response[0]['Epoch']
assert response[0]['Name'] == 'aajohan-comfortaa-fonts-3.001-2.el8.noarch'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we avoid the hardcoding of version?

tests/foreman/ui/test_contentview.py Outdated
assert package_name in response[0]['Name']
assert response[0]['Epoch']
assert response[0]['Name'] == 'aajohan-comfortaa-fonts-3.001-2.el8.noarch'
assert response[0]['Version'] == '3.001'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

tests/foreman/ui/test_contentview.py Outdated Show resolved Hide resolved
vsedmik
vsedmik reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small proposal.

tests/foreman/ui/test_contentview.py Outdated Show resolved Hide resolved
@sambible
Copy link
Contributor Author

sambible commented May 7, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_contentview.py -k test_version_table_read
airgun: 1083

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6836
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_contentview.py -k test_version_table_read --external-logging
Test Result : =========== 1 failed, 2 deselected, 16 warnings in 819.66s (0:13:39) ===========

vsedmik
vsedmik approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, pending PRT pass (seems like some airgun tweak is needed).

@sambible
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_contentview.py -k test_version_table_read
airgun: 1083

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6880
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_contentview.py -k test_version_table_read --external-logging
Test Result : =========== 1 failed, 2 deselected, 16 warnings in 850.71s (0:14:10) ===========

@sambible
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_contentview.py -k test_version_table_read
airgun: 1083

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6881
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_contentview.py -k test_version_table_read --external-logging
Test Result : =========== 1 passed, 2 deselected, 16 warnings in 920.91s (0:15:20) ===========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels May 10, 2024
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label May 10, 2024
@vsedmik vsedmik mentioned this pull request May 10, 2024
Merged
@vsedmik vsedmik added 6.16.z AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing labels Jun 3, 2024
@vsedmik vsedmik merged commit 83c2093 into SatelliteQE:master Jun 3, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 3, 2024
@sambible @web-flow
[CV Eval] CV Version Test (#14949)
fc425c7 
* Add test reading CV Version table

* Add test reading CV Version table

* Add additional checks for table fields

* Add test reading CV Version table

* Add additional checks for table fields

* Fix caseimportance string

* Use only REPOS constant

* Read data from product to compare in table, and use smaller repo

(cherry picked from commit 83c2093)
This was referenced Jun 3, 2024
Open
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shweta83 shweta83 shweta83 requested changes

@vsedmik vsedmik vsedmik approved these changes

@damoore044 damoore044 damoore044 approved these changes

@ColeHiggins2 ColeHiggins2 Awaiting requested review from ColeHiggins2

@vijaysawant vijaysawant Awaiting requested review from vijaysawant

Assignees

@sambible sambible

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sambible @Satellite-QE @shweta83 @vsedmik @damoore044