Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV UI - Add versions screen, and capability to search/read all tables #1083

Merged
merged 4 commits into from
Jun 3, 2024

Conversation

sambible
Copy link
Contributor

@sambible sambible commented Dec 15, 2023

Airgun Support for the Versions screen of CV UI - supports reading/searching all tables.

Robottelo PR exercising this: SatelliteQE/robottelo#13478

Copy link
Contributor

@damoore044 damoore044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@omkarkhatavkar
Copy link
Collaborator

@sambible Looks overall good, just a smaller non-blocking comment.

airgun/views/contentview_new.py Show resolved Hide resolved
airgun/views/contentview_new.py Outdated Show resolved Hide resolved
airgun/views/contentview_new.py Outdated Show resolved Hide resolved
airgun/views/contentview_new.py Outdated Show resolved Hide resolved
airgun/views/contentview_new.py Show resolved Hide resolved
Use single quotation instead of double

Co-authored-by: vijay sawant <[email protected]>
Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@omkarkhatavkar omkarkhatavkar merged commit b649a9d into SatelliteQE:master Jun 3, 2024
6 checks passed
damoore044 pushed a commit to damoore044/airgun that referenced this pull request Jun 22, 2024
…SatelliteQE#1083)

* Add versions screen, and capability to search/read all tables

* Change field name and remove commented field

* Better locator for versions tab

* Apply suggestions from code review

Use single quotation instead of double

Co-authored-by: vijay sawant <[email protected]>

---------

Co-authored-by: vijay sawant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z 6.14.z 6.15.z CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants