browser teardown fix at session exit #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The browser teardown in `airgun.session.Session.__exit__` should be executed only once. Because when `Session` is nested in multiple context managers(*), the `__exit__` method is called for each one and this causes that the second and further `webdriver.quit()` call will fail, because the browser session was already stopped. (*) for example in the robottelo `session` fixture in `robottelo/pytest_fixtures/core/ui.py`.
pnovotny
added
6.12.z
CherryPick
omkarkhatavkar
approved these changes
May 23, 2024
|
This needs to be merged as it is highly dependent on the Robottelo PR. |
github-actions bot
pushed a commit
that referenced
this pull request
May 23, 2024
The browser teardown in `airgun.session.Session.__exit__` should be executed only once. Because when `Session` is nested in multiple context managers(*), the `__exit__` method is called for each one and this causes that the second and further `webdriver.quit()` call will fail, because the browser session was already stopped. (*) for example in the robottelo `session` fixture in `robottelo/pytest_fixtures/core/ui.py`. (cherry picked from commit d9cfc90)
Satellite-QE
added a commit
that referenced
this pull request
May 23, 2024
This was referenced Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
When nesting
airgun.session.Sessionin multiple context managers (like robottelosessionfixture does),the
__exit__method, which handles browser teardown, is called mutliple times as well.This causes that the second and further attempt to call
webdriver.quit()will fail,because the browser was already closed.
Solution
Execute the browser teardown only once.
Related Issues
Needed for SatelliteQE/robottelo#15050