Skip to content

Commit

Permalink
session: execute browser teardown only once (#1390) (#1396)
Browse files Browse the repository at this point in the history
  • Loading branch information
Satellite-QE authored May 23, 2024
1 parent b73f959 commit 4886124
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions airgun/session.py
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ def __exit__(self, exc_type, exc_value, traceback):
not risen not to shadow real session result.
"""
if self.browser is None:
# browser was never started, don't do anything
# browser hasn't been started or was already closed, don't do anything
return
LOGGER.info('Stopping UI session %r for user %r', self.name, self._user)
passed = True if exc_type is None else False
Expand All @@ -238,7 +238,7 @@ def __exit__(self, exc_type, exc_value, traceback):
except Exception as err: # - TODO: fix bare except
LOGGER.exception(err)
finally:
self._factory.finalize(passed)
self.browser = self._factory.finalize(passed)

def _open(self, entity):
"""Initializes requested entity. If this is first time session
Expand Down

0 comments on commit 4886124

Please sign in to comment.