Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNJ and SubFst Quests and EventMgr Fixes #954

Merged
merged 5 commits into from
May 13, 2024

Conversation

pinapelz
Copy link
Contributor

  • Implemented missing CNJ job quests

  • Add bounds checking to SubFst011 to prevent repeated EventNotices being sent when quest conditions are already met

  • Remove casting condition from player on eventFinish in EventMgr
    This fixes an issue in all quests where using a key item with some cast time on some object results in the player being stuck in a casting state and unable to do anything except move

  • Scene00099 in SubFst009 causes the server to infinitely attempt to return from it. Not actually needed here since there's no additional dialogue for cancelling the turn in so I don't think that scene is used.

output from cancelling turn in with Scene00099

[11:42:16.053] [debug] 		 TARGET_DECIDE | 3 ( p1:E0000000 p11:E0000000 p12:0 p2:0 p3:0 p4:0 )
[11:42:16.360] [debug] [2097154] Zone IPC : StartTalkEvent ( 01C2 )
[11:42:17.823] [debug] [2097154] Zone IPC : Command ( 0191 )
[11:42:17.823] [debug] 		 TARGET_DECIDE | 3 ( p1:100117A92 p11:117A92 p12:1 p2:0 p3:0 p4:0 )
[11:42:20.608] [debug] [2097154] Zone IPC : ReturnEventScene2 ( 01D7 )
[11:42:22.327] [debug] [2097154] Zone IPC : ReturnEventScene2 ( 01D7 )
[11:42:23.775] [debug] [2097154] Zone IPC : ReturnEventScene2 ( 01D7 )
[11:42:25.537] [debug] [2097154] Zone IPC : ReturnEventScene2 ( 01D7 )

pinapelz and others added 5 commits January 17, 2024 20:51
- ClsCnj998
- ClsCnj999
Prevents repeated excess quest progress event notices if Enemy0 is killed after kill count is already reached
fixes issue where using EventItemAction during quests makes the player stuck casting
Scene00099 doesn't do anything and causes server to infinitely attempt to return from it
@NotAdam NotAdam merged commit 2866e67 into SapphireServer:master May 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants