Minor ItemAction and Player Title fixes #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- index 0 is None in-game removing the currently equipped title
takhlaq
approved these changes
Jan 11, 2024
IceyMint
pushed a commit
to IceyMint/Sapphire
that referenced
this pull request
Sep 8, 2024
Minor ItemAction and Player Title fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing
handleSongItemitem action. The function to register an orchestrion roll was already implemented in Player.cpp but was just missing the handler function.Added additional condition to allow for currently equipped title to be removed. titleID = 0 corresponds to the "None" entry in the title selection menu, all players already have this