Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[record-hessian] RecordHessian resolve a compile issue. #14298

Merged
merged 4 commits into from
Nov 6, 2024
Merged

[record-hessian] RecordHessian resolve a compile issue. #14298

merged 4 commits into from
Nov 6, 2024

Conversation

BLee-bot
Copy link
Contributor

@BLee-bot BLee-bot commented Nov 5, 2024

This resolves compile issue.

ONE-DCO-1.0-Signed-off-by: Banseok Lee [email protected]

Related Issue : #13480
Draft PR: #13585

@seanshpark
Copy link
Contributor

plz correct commit message

current is

image

@seanshpark
Copy link
Contributor

seanshpark commented Nov 6, 2024 •
edited
Loading

current commit message is

image

plz begin [recor...] tag and revise title/description with what this changes does.

@seanshpark seanshpark mentioned this pull request Nov 6, 2024
Open
@BLee-bot
Copy link
Contributor Author

BLee-bot commented Nov 6, 2024 •
edited
Loading

current commit message is

image

plz begin [recor...] tag and revise title/description with what this changes does.

Ok, will add [record-hessian] and more detailed descriptiuon at all commit message.

@seanshpark
Copy link
Contributor

seanshpark commented Nov 6, 2024 •
edited
Loading

Your new message is

 [record-hessian] This commit add linking nncc_common to record-hessian.

This commit add linking nncc_common to record-hessian.

Add target_link_libraries(record-hessian nncc_common) in CMakeLists.txt

I wrote "what this changes does." in review comment.

What I see in this PR are;

  • this changes does add linking nncc_common
  • this changes fixes errors with strict compilation option

Add target_link_libraries(record-hessian nncc_common) in CMakeLists.txt looks too detail.

If you have any more problems reading my comments, feel free to ask.

@BLee-bot
Copy link
Contributor Author

BLee-bot commented Nov 6, 2024

Your new message is

 [record-hessian] This commit add linking nncc_common to record-hessian.

This commit add linking nncc_common to record-hessian.

Add target_link_libraries(record-hessian nncc_common) in CMakeLists.txt

I wrote "what this changes does." in review comment.

What I see in this PR are;

  • this changes does add linking nncc_common
  • this changes fixes errors with strict compilation option

Add target_link_libraries(record-hessian nncc_common) in CMakeLists.txt looks too detail.

If you have any more problems reading my comments, feel free to ask.

I appreciate your detailed guides.
One thing I need to be sure is that.. You mean the first commit of this PR, right? Not all commits I pushed?

@seanshpark
Copy link
Contributor

first commit of this PR, right?

Yes, first commit message will be used for this PR.

@seanshpark
Copy link
Contributor 

This changes does add linking nncc_common
This changes fixes errors with strict compilation option

This wordings are from my point of view to describe what I understood,
and I don't think these are for the commit message.

@BLee-bot
[record-hessian] Add linking nncc_common to record-hessian (Samsung#1…
e3e325f 
…4298)

This add linking nncc_common in CMakeLists. Fixes errors with strict compilation option.

ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
@BLee-bot
[record-hessian]Fix build errors due to add nncc_common.
1c97c10 
Fix build errors due to add nncc_common.
Change int -> uint32_t.

ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
@BLee-bot
[record-hessian]Delete unused variable and argument.
353c065 
Delete unused variable and argument.

ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
@BLee-bot
[record-hessian]Fix build errors due to AffineQuantization.
af785a3 
Fix build errors due to AffineQuantization.

ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
seanshpark
seanshpark approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark seanshpark merged commit a976405 into Samsung:master Nov 6, 2024
8 checks passed
BLee-bot added a commit to BLee-bot/ONE that referenced this pull request Nov 6, 2024
@BLee-bot
[record-hessian] RecordHessian resolve a compile issue. (Samsung#14298)
b2f98eb 
This add linking nncc_common in CMakeLists. Fixes errors with strict compilation option.

ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
BLee-bot added a commit to BLee-bot/ONE that referenced this pull request Nov 11, 2024
@BLee-bot
[record-hessian] RecordHessian resolve a compile issue. (Samsung#14298)
0f361d7 
This add linking nncc_common in CMakeLists. Fixes errors with strict compilation option.

ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
BLee-bot added a commit to BLee-bot/ONE that referenced this pull request Nov 11, 2024
@BLee-bot
[record-hessian] RecordHessian resolve a compile issue. (Samsung#14298)
4dd5c0b 
This add linking nncc_common in CMakeLists. Fixes errors with strict compilation option.

ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
BLee-bot added a commit to BLee-bot/ONE that referenced this pull request Nov 20, 2024
@BLee-bot
[record-hessian] Resolve a compile issue. (Samsung#14298)
69c3351 
This add linking nncc_common in CMakeLists. Fixes errors with strict compilation option.

ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanshpark seanshpark seanshpark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BLee-bot @seanshpark