Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[record-hessian] Introduce RecordHessian. #14295

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

BLee-bot
Copy link
Contributor

@BLee-bot BLee-bot commented Nov 4, 2024

This introduces a part of RecordHessian.

ONE-DCO-1.0-Signed-off-by: Banseok Lee [email protected]

Related Issue : #13480
Draft PR: #13585

@seanshpark
Copy link
Contributor

seanshpark commented Nov 4, 2024

will continue review after #14297 #14298 lands and this PR is rebased on that.

@seanshpark seanshpark added the PR/NO MERGE Please don't merge. I'm still working on this :) label Nov 4, 2024
This commit introduce record hessian.

ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
BLee-bot and others added 3 commits November 11, 2024 10:38
This add linking nncc_common in CMakeLists. Fixes errors with strict compilation option.

ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Delete unused variables and lines.

ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Apply feed back, make comment more precise.

ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
@seanshpark
Copy link
Contributor

Your current commit title/message is

[record-hessian] This commit introduce record hessian.
This commit introduce record hessian.

which doesn't seem to express current changes.
1/ please fix the title/comment to represent current changes
2/ there are "update" changes and "add" changes. plz split them to separate PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/NO MERGE Please don't merge. I'm still working on this :)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants