Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[record-minmax] Tidy RecordMinMax #14267

Merged
merged 1 commit into from
Oct 29, 2024
Merged

[record-minmax] Tidy RecordMinMax #14267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions compiler/record-minmax/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ set(TEST_SOURCES
file(GLOB_RECURSE TESTS "tests/*.test.cpp")

nnas_find_package(GTest REQUIRED)
GTest_AddTest(record_minmax_function_test ${TESTS} ${TEST_SOURCES})
target_include_directories(record_minmax_function_test PRIVATE include)
target_link_libraries(record_minmax_function_test luci_lang)
target_link_libraries(record_minmax_function_test nncc_coverage)
GTest_AddTest(record_minmax_unittest ${TESTS} ${TEST_SOURCES})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed this test because unittest is a more widely-used term.

target_include_directories(record_minmax_unittest PRIVATE include)
target_link_libraries(record_minmax_unittest luci_lang)
target_link_libraries(record_minmax_unittest nncc_coverage)
9 changes: 0 additions & 9 deletions compiler/record-minmax/include/RecordMinMax.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,15 +71,6 @@ class RecordMinMax

void profileDataInParallel(const std::string &input_data_path);

// TODO Remove unused code
#if 0
void profileRawData(const std::string &input_data_path);

void profileRawDataDirectory(const std::string &input_data_path);

void profileDataWithRandomInputs(void);
#endif

void saveModel(const std::string &output_model_path);

private:
Expand Down
Loading