[record-minmax] Tidy RecordMinMax #14267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tidies RecordMinMax source code. - Remove unused code - Use proper test name ONE-DCO-1.0-Signed-off-by: Hyukjin Jeong <[email protected]>
jinevening
commented
Oct 28, 2024
| target_include_directories(record_minmax_function_test PRIVATE include) | ||
| target_link_libraries(record_minmax_function_test luci_lang) | ||
| target_link_libraries(record_minmax_function_test nncc_coverage) | ||
| GTest_AddTest(record_minmax_unittest ${TESTS} ${TEST_SOURCES}) |
There was a problem hiding this comment.
I renamed this test because unittest is a more widely-used term.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tidies RecordMinMax source code.
ONE-DCO-1.0-Signed-off-by: Hyukjin Jeong [email protected]
Related to: #14255
Draft PR: #14257