-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: [onert] block quantization #13693
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hseok-oh
changed the title
Draft: [onert] blockwise quantization
Draft: [onert] block quantization
Aug 19, 2024
hseok-oh
changed the title
Draft: [onert] block quantization
Draft: [onert] chunk quantization
Aug 20, 2024
Blockwise quantization: uint4 / int8 with 32 block size, fp16 delta. ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <[email protected]>
hseok-oh
force-pushed
the
draft/block_quant
branch
from
August 23, 2024 02:07
d602282
to
f4ce5ba
Compare
glistening
reviewed
Aug 27, 2024
nnpackage/schema/circle_schema.fbs
Outdated
// Represents a specific quantization technique's parameters. | ||
union QuantizationDetails { | ||
CustomQuantization, | ||
CircleBlockQuantization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the prefix Circle
necessary to avoid name conflict from flatbuffers generated files? I guess GGMLBlockQuantization
may be better as @jinevening suggested offline. It makes it clear what CircleBlockQuantization
means.
hseok-oh
changed the title
Draft: [onert] chunk quantization
Draft: [onert] block quantization
Aug 28, 2024
hseok-oh
force-pushed
the
draft/block_quant
branch
from
August 28, 2024 07:43
8634ae4
to
d0d592c
Compare
This was referenced Aug 29, 2024
All merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support runtime block quantization: uint4 / int8 with 32 chunk size, fp16 delta.
ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh [email protected]