Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert] Support block quantization operand size calculation #13886

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

hseok-oh
Copy link
Contributor

@hseok-oh hseok-oh commented Sep 2, 2024

This commit update total_size() method to calculate block quantization type operand size.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh [email protected]


Related issue: #13742
Draft: #13693

@hseok-oh hseok-oh added the PR/ready for review It is ready to review. Please review it. label Sep 2, 2024
@hseok-oh hseok-oh requested a review from a team September 2, 2024 06:42

#include "ir/OperandInfo.h"

#include <cassert>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(optional) Is this for future? This file seems not have assert.

This commit update total_size() method to calculate block quantization type operand size.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <[email protected]>
zetwhite
zetwhite previously approved these changes Sep 2, 2024
Copy link
Contributor

@zetwhite zetwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without typo, the code looks good 👍

Copy link
Contributor

@glistening glistening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glistening glistening merged commit 8593953 into Samsung:master Sep 3, 2024
9 checks passed
@hseok-oh hseok-oh deleted the block_size_calc branch September 4, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants