Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAYRTS-5580 Fix titles in podcast section of radios #502

Merged
merged 14 commits into from
Aug 2, 2024

Conversation

mutaben
Copy link
Contributor

@mutaben mutaben commented Jul 10, 2024

Description

Section titles in Podcast channels (present for RTS and RSI) were misleading since they mentioned "shows" in their strings or terminology associated with radio.

This PR fixes this.

Changes Made

  • The remote config object for radios now hold a new property showType which can be either show or podcast
  • This new property is parsed
  • Then the enums associated with determining the titles are set properly to be able to differentiate between the two types of channels

Checklist

  • I have followed the project's style guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • My changes do not generate new warnings.
  • I have tested my changes and I am confident that it works as expected and doesn't introduce any known regressions.
  • I have reviewed the contribution guidelines.

@mutaben mutaben added the improvement Feature or update (issue and PR) - release notes section label Jul 10, 2024
@mutaben mutaben requested a review from pyby July 10, 2024 13:30
@mutaben
Copy link
Contributor Author

mutaben commented Jul 10, 2024

As you can see, I have only updated the Localizable.strings file for RTS.

If I understood correctly, we can pull those new localizations in CrowdIn and then localize them in other languages?

cc @pyby @Loic-Dumas @pradie-charlotte

@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYRTS-5580-podcasts-titles July 10, 2024 15:24 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYRTS-5580-podcasts-titles July 10, 2024 15:24 Inactive
@pyby
Copy link
Member

pyby commented Jul 10, 2024

If I understood correctly, we can pull those new localizations in CrowdIn and then localize them in other languages?

Yes, a first documentation is here, as we shared: https://github.com/SRGSSR/playsrg-apple?tab=readme-ov-file#translations
Probably, we need to improve it with more detail about the "raw" versioned files in English in Translations folder.

Copy link
Member

@pyby pyby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First review.

  • Some architectures choice should be refined.
  • Some UI check to be done on the audio channel page, AZ page and by date page.

Application/Sources/Calendar/CalendarViewController.m Outdated Show resolved Hide resolved
Application/Sources/Configuration/Channel.h Outdated Show resolved Hide resolved
Application/Sources/Configuration/RadioChannel.swift Outdated Show resolved Hide resolved
docs/REMOTE_CONFIGURATION.md Outdated Show resolved Hide resolved
Application/Sources/Configuration/Channel.h Outdated Show resolved Hide resolved
Application/Sources/Configuration/Channel.h Outdated Show resolved Hide resolved
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYRTS-5580-podcasts-titles July 12, 2024 12:31 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYRTS-5580-podcasts-titles July 12, 2024 12:31 Inactive
@mutaben mutaben requested a review from pyby July 15, 2024 08:52
Copy link
Member

@pyby pyby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next step: ask Italian translations.

docs/REMOTE_CONFIGURATION.md Outdated Show resolved Hide resolved
@pyby pyby changed the title PLAYRTS-5580 - Fix titles in podcast section of radios PLAYRTS-5580 Fix titles in podcast section of radios Jul 22, 2024
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYRTS-5580-podcasts-titles July 23, 2024 07:06 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYRTS-5580-podcasts-titles July 23, 2024 07:15 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYRTS-5580-podcasts-titles July 23, 2024 07:48 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYRTS-5580-podcasts-titles July 25, 2024 19:15 Inactive
@mutaben mutaben added this pull request to the merge queue Jul 29, 2024
@mutaben mutaben removed this pull request from the merge queue due to a manual request Jul 29, 2024
@pyby
Copy link
Member

pyby commented Jul 29, 2024

Next step: ask Italian translations.

Did it. ✅

@mutaben mutaben added this pull request to the merge queue Aug 2, 2024
Merged via the queue into develop with commit 38efce3 Aug 2, 2024
2 checks passed
@mutaben mutaben deleted the feature/PLAYRTS-5580-podcasts-titles branch August 2, 2024 21:49
@pyby pyby changed the title PLAYRTS-5580 Fix titles in podcast section of radios PLAYRTS-5580 Fix titles in iOS podcast section of radios Aug 26, 2024
@pyby pyby changed the title PLAYRTS-5580 Fix titles in iOS podcast section of radios PLAYRTS-5580 Fix titles in podcast section of radios Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Feature or update (issue and PR) - release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants