-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLAYRTS-5580 Fix titles in podcast section of radios #502
Conversation
As you can see, I have only updated the If I understood correctly, we can pull those new localizations in CrowdIn and then localize them in other languages? |
Yes, a first documentation is here, as we shared: https://github.com/SRGSSR/playsrg-apple?tab=readme-ov-file#translations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First review.
- Some architectures choice should be refined.
- Some UI check to be done on the audio channel page, AZ page and by date page.
Application/Sources/Configuration/ApplicationConfiguration.swift
Outdated
Show resolved
Hide resolved
Application/Sources/Configuration/ApplicationConfiguration.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Pierre-Yves <[email protected]>
…tching at the latest level
Co-authored-by: Pierre-Yves <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next step: ask Italian translations.
Application/Resources/Apps/Play RSI/ApplicationConfiguration.json
Outdated
Show resolved
Hide resolved
Application/Resources/Apps/Play RTS/ApplicationConfiguration.json
Outdated
Show resolved
Hide resolved
…nfiguration.json Co-authored-by: Pierre-Yves <[email protected]>
Co-authored-by: Pierre-Yves <[email protected]>
…nfiguration.json Co-authored-by: Pierre-Yves <[email protected]>
Did it. ✅ |
Description
Section titles in Podcast channels (present for RTS and RSI) were misleading since they mentioned "shows" in their strings or terminology associated with radio.
This PR fixes this.
Changes Made
showType
which can be eithershow
orpodcast
Checklist