Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netskope - fix trigger configuration #1230

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Netskope - fix trigger configuration #1230

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fbefb6a
Netskope - fix trigger configuration
lvoloshyn-sekoia Dec 13, 2024
b5b4ee5
Fix
lvoloshyn-sekoia Dec 13, 2024
c403d02
Add changelog record
lvoloshyn-sekoia Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Netskope/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"name": "Netskope",
"uuid": "1e3f2e33-fb9c-4387-bcf7-8d7ece37f913",
"slug": "netskope",
"version": "1.11.0",
"version": "1.11.1",
"categories": [
"Network"
]
Expand Down
9 changes: 8 additions & 1 deletion Netskope/netskope_modules/connector_pull_events_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,13 @@
(NetskopeEventType.ALERT, NetskopeAlertType.UBA),
]

@cached_property
def configuration_uuid(self) -> str:
if self.module.connector_configuration_uuid is not None:
return self.module.connector_configuration_uuid

Check warning on line 183 in Netskope/netskope_modules/connector_pull_events_v2.py

View check run for this annotation

Codecov / codecov/patch

Netskope/netskope_modules/connector_pull_events_v2.py#L183 

Added line #L183 was not covered by tests

return self.module.trigger_configuration_uuid

def get_index_name(self, event_type: NetskopeEventType, alert_type: NetskopeAlertType | None) -> str:
"""
return a index name for the iterator
Expand All @@ -188,7 +195,7 @@
if self.configuration.consumer_group and len(self.configuration.consumer_group) > 0:
return self.configuration.consumer_group

return get_index_name(self.module.trigger_configuration_uuid, event_type, alert_type)
return get_index_name(self.configuration_uuid, event_type, alert_type)

def create_iterator(self, event_type: NetskopeEventType, alert_type: NetskopeAlertType | None) -> NetskopeIterator:
params: dict[str, str] = {
Expand Down
Loading