-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Netskope - fix trigger configuration #1230
base: main
Are you sure you want to change the base?
Conversation
26aef8b
to
b5b4ee5
Compare
Test Results22 tests - 74 20 ✅ - 75 1m 4s ⏱️ + 1m 2s Results for commit c403d02. ± Comparison against base commit 08530d1. This pull request removes 96 and adds 22 tests. Note that renamed tests count towards both.
This pull request removes 1 skipped test and adds 2 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me.
However, can you add an entry in the CHANGELOG.md file? Thank you
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1230 +/- ##
==========================================
- Coverage 91.71% 90.54% -1.17%
==========================================
Files 20 29 +9
Lines 953 1280 +327
==========================================
+ Hits 874 1159 +285
- Misses 79 121 +42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
75bf18f
to
c403d02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
https://github.com/SekoiaLab/integration/issues/324