Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netskope - fix trigger configuration #1230

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lvoloshyn-sekoia
Copy link
Collaborator

@lvoloshyn-sekoia lvoloshyn-sekoia commented Dec 13, 2024

@lvoloshyn-sekoia lvoloshyn-sekoia marked this pull request as ready for review December 13, 2024 16:25
@lvoloshyn-sekoia lvoloshyn-sekoia force-pushed the lv/fix_netskope_connector branch from 26aef8b to b5b4ee5 Compare December 13, 2024 16:28
Copy link

github-actions bot commented Dec 13, 2024

Test Results

22 tests   - 74   20 ✅  - 75   1m 4s ⏱️ + 1m 2s
 1 suites ± 0    2 💤 + 1 
 1 files   ± 0    0 ❌ ± 0 

Results for commit c403d02. ± Comparison against base commit 08530d1.

This pull request removes 96 and adds 22 tests. Note that renamed tests count towards both.
tests.ic_oc_triggers.test_alerts ‑ test_alert_trigger_filter_by_rule
tests.ic_oc_triggers.test_alerts ‑ test_comment_trigger_filter_by_rule
tests.ic_oc_triggers.test_alerts ‑ test_comment_trigger_filter_notification_function
tests.ic_oc_triggers.test_alerts ‑ test_invalid_events_dont_triggers_comments_added
tests.ic_oc_triggers.test_alerts ‑ test_securityalertstrigger_handle_alert_invalid_message
tests.ic_oc_triggers.test_alerts ‑ test_securityalertstrigger_handle_alert_send_message
tests.ic_oc_triggers.test_alerts ‑ test_securityalertstrigger_handler_dispatch_alert_message
tests.ic_oc_triggers.test_alerts ‑ test_securityalertstrigger_init
tests.ic_oc_triggers.test_alerts ‑ test_securityalertstrigger_retrieve_alert_from_api
tests.ic_oc_triggers.test_alerts ‑ test_securityalertstrigger_retrieve_alert_from_api_exp_raised
…
tests.test_helpers ‑ test_get_index_name
tests.test_helpers ‑ test_get_iterator_name
tests.test_helpers ‑ test_get_tenant_hostname
tests.test_pubsub_lite ‑ test_configuration
tests.test_pubsub_lite ‑ test_process_messages[data1\ndata2\ndata3-expected_events0]
tests.test_pubsub_lite ‑ test_process_messages[data1\ndata\xd8\ndata3-None]
tests.test_pubsub_lite ‑ test_run
tests.test_pull_events_v2_connector ‑ test_create_iterators
tests.test_pull_events_v2_connector ‑ test_fetch_next_batch_integration
tests.test_pull_events_v2_connector ‑ test_long_next_batch_should_not_sleep
…
This pull request removes 1 skipped test and adds 2 skipped tests. Note that renamed tests count towards both.
tests.ic_oc_triggers.test_intelligence ‑ test_run
tests.test_pull_events_v2_connector ‑ test_fetch_next_batch_integration
tests.test_pull_events_v2_connector ‑ test_run_integration

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@squioc squioc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me.
However, can you add an entry in the CHANGELOG.md file? Thank you

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.54%. Comparing base (08530d1) to head (b5b4ee5).

Files with missing lines Patch % Lines
...skope/netskope_modules/connector_pull_events_v2.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1230      +/-   ##
==========================================
- Coverage   91.71%   90.54%   -1.17%     
==========================================
  Files          20       29       +9     
  Lines         953     1280     +327     
==========================================
+ Hits          874     1159     +285     
- Misses         79      121      +42     
Flag Coverage Δ
Netskope 87.15% <83.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@squioc squioc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants