Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Adapt JSDocs for new CЕM and Remove Redundancies #7829

Closed
wants to merge 92 commits into from
Closed
Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
92 commits
Select commit Hold shift + click to select a range
04271de
docs: generate cem
Sep 20, 2023
ce8470f
chore: cleanup
Sep 20, 2023
53558c0
chore: migrate button
Sep 26, 2023
34fa365
chore: generate manifest for base
Sep 26, 2023
4271fab
chore: cleanup
Sep 26, 2023
2c02ab8
Merge remote-tracking branch 'origin/main' into new-cem
vladitasev Oct 4, 2023
91ba52e
chore: enhance
Oct 3, 2023
d9d58c4
chore: align storybook to use cem
Oct 9, 2023
7387bcc
chore: 09/10
Oct 9, 2023
96fdd35
chore: 10.10
Oct 10, 2023
cb0517b
chore: add validator for manifest
Oct 11, 2023
feae7c7
chore: add valid jsdoc tags
Oct 11, 2023
9c36b48
chore: improve validators
Oct 12, 2023
9c59c34
chore: migrate samples prepare to storybook
Oct 13, 2023
7ad3425
chore: ts
Oct 16, 2023
beb9d97
chore: fix missing tags
Oct 17, 2023
a7784a9
Merge branch 'main' into new-cem
Oct 17, 2023
161857c
chore: clean
Oct 17, 2023
19f59fb
chore: correct deps
Oct 17, 2023
7872477
chore: fix scripts
Oct 17, 2023
1a12b35
chore: validate tags
Oct 17, 2023
fa487fc
chore: optional execution of script
Oct 17, 2023
a1f7f14
chore: sampels docs
Oct 17, 2023
4394906
chore: restore previous scripts and enable cem for base
Oct 17, 2023
05b188f
chore: fix validation of @default
Oct 17, 2023
31ce716
chore: fix storybook build
Oct 17, 2023
2550a0b
chore: fix schema and add missing tags
Oct 18, 2023
38f4cce
Merge remote-tracking branch 'origin' into new-cem
Oct 19, 2023
6fa80f9
chore: restore bundle
Oct 19, 2023
a28e5f5
chore: add param type
Oct 19, 2023
5b5793d
Merge remote-tracking branch 'origin' into new-cem
Oct 19, 2023
3b2708a
chore: generate new manifest
Oct 20, 2023
b7ba762
fix: chore description
Oct 20, 2023
3923f9b
fix: param / unnamed slots privacy
Oct 20, 2023
0ebecca
chore: show css parts
Oct 23, 2023
00e28cb
chore: extract storybook
Oct 23, 2023
99bbfe3
chore: restore nps script
Oct 23, 2023
c60651c
chore: restore component migration
Oct 23, 2023
4483b88
Merge remote-tracking branch 'origin' into new-cem
Oct 23, 2023
61d9625
fix: default value
Oct 23, 2023
e9ed3e2
fix: enum schema validation
Oct 25, 2023
7d71521
fix: show interfaces
Oct 27, 2023
64f15d0
fix: ts files path
Oct 31, 2023
962816c
Merge remote-tracking branch 'origin' into new-cem
Nov 7, 2023
ab8d01b
docs: Adapt JSDocs for new CЕM and Remove Redundancies
NHristov-sap Nov 9, 2023
2582ea8
chore: refacotor, fix validation, add internal json
Nov 10, 2023
ec5d441
docs: fix merge conflict
NHristov-sap Nov 10, 2023
ecfa2bc
chore: update schema and validation
Nov 10, 2023
99e04af
Merge remote-tracking branch 'origin' into new-cem
Nov 10, 2023
1bdc15a
chore: add yarnlock
Nov 10, 2023
e10177e
Merge remote-tracking branch 'origin' into new-cem
Nov 10, 2023
cd086e3
chore: fix event param types
Nov 10, 2023
94a3f1d
fix: show event params
Nov 13, 2023
a0badba
fix: display only public ones
Nov 13, 2023
1484baf
chore: restore input paths
Nov 13, 2023
b7f91c0
Merge branch 'main' into BL_doc_change
NHristov-sap Nov 14, 2023
30308d2
Merge remote-tracking branch 'origin' into new-cem
Nov 14, 2023
22e0cac
chore: refactor
Nov 14, 2023
24039b5
chore: update schema
Nov 14, 2023
aadf607
chore: restore paths
Nov 14, 2023
4f8a400
docs: adapt docs to updated specs
NHristov-sap Nov 14, 2023
8ba84e9
docs: fix storybook errors
NHristov-sap Nov 15, 2023
ed08e7e
docs: add missing file
NHristov-sap Nov 15, 2023
621fb6c
docs: update interfaces
NHristov-sap Nov 16, 2023
231da31
Merge remote-tracking branch 'origin' into new-cem
Nov 20, 2023
c1965f5
chore: add override for getters, methods, props
Nov 20, 2023
a332a43
docs: fix comments
NHristov-sap Nov 21, 2023
7a3954f
docs: new cem for Topic-P components - Icon (#7810)
plamenivanov91 Nov 21, 2023
29ddd0b
Merge remote-tracking branch 'origin/main' into new-cem
Nov 21, 2023
8d79551
docs: new cem for Topic-P components - ShellBar (#7823)
plamenivanov91 Nov 21, 2023
af54a8c
Merge remote-tracking branch 'origin/new-cem' into new-cem
Nov 21, 2023
20ba50e
chore: add privacy for shellbar events
Nov 21, 2023
f895ef2
docs: fix more comments
NHristov-sap Nov 21, 2023
f843671
Merge branch 'main' into BL_doc_change
NHristov-sap Nov 21, 2023
d8de813
chore: ehnance validator
Nov 22, 2023
b675009
docs: another comments fix
NHristov-sap Nov 23, 2023
04598ad
chore: add storybook
Nov 23, 2023
ccb2eee
Merge branch 'BL_doc_change' of https://github.com/SAP/ui5-webcompone…
NHristov-sap Nov 23, 2023
0d84bbd
chore: migrate base package
Nov 23, 2023
75e62dd
chore: add correct export definition
Nov 26, 2023
61a24c2
Merge remote-tracking branch 'origin/main' into new-cem
Nov 26, 2023
531ed44
docs(ui5-rating-indicator): improve documentation (#7915)
niyap Nov 27, 2023
5f1a3f4
Merge remote-tracking branch 'origin/new-cem' into new-cem
Nov 27, 2023
3f9a02b
docs: fix more comments
NHristov-sap Nov 27, 2023
28b726b
docs(ui5-textarea): improve documentation (#7913)
niyap Nov 27, 2023
92ab975
chore: fix some components values and make storybook to work
Nov 27, 2023
0032fa6
docs(ui5-slider, ui5-range-slider): enhance documentation (#7910)
niyap Nov 27, 2023
3dabefe
chore: cleanup
Nov 27, 2023
1c71230
docs: new cem for Topic-P components - Toolbar (#7814)
plamenivanov91 Nov 28, 2023
eb847ea
docs: new cem for Topic-P components - List (#7824)
plamenivanov91 Nov 28, 2023
9d6ae8d
chore: fulfill list
Nov 28, 2023
b3eb83f
Merge branch 'new-cem' into BL_doc_change
NHristov-sap Nov 28, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions packages/base/src/types/CalendarType.ts
Original file line number Diff line number Diff line change
@@ -1,36 +1,27 @@
/**
* Different calendar types.
*
* @readonly
* @enum {string}
* @public
* @author SAP SE
* @alias sap.ui.webc.base.types.CalendarType
*/
enum CalendarType {
/**
* @public
* @type {Gregorian}
*/
Gregorian = "Gregorian",
/**
* @public
* @type {Islamic}
*/
Islamic = "Islamic",
/**
* @public
* @type {Japanese}
*/
Japanese = "Japanese",
/**
* @public
* @type {Buddhist}
*/
Buddhist = "Buddhist",
/**
* @public
* @type {Persian}
*/
Persian = "Persian",
}
Expand Down
8 changes: 0 additions & 8 deletions packages/base/src/types/NavigationMode.ts
Original file line number Diff line number Diff line change
@@ -1,31 +1,23 @@
/**
* Different navigation modes for ItemNavigation.
*
* @readonly
* @enum {string}
* @public
* @author SAP SE
* @alias sap.ui.webc.base.types.NavigationMode
*/
enum NavigationMode {
/**
* @public
* @type {Auto}
*/
Auto = "Auto",
/**
* @public
* @type {Vertical}
*/
Vertical = "Vertical",
/**
* @public
* @type {Horizontal}
*/
Horizontal = "Horizontal",
/**
* @public
* @type {Paging}
*/
Paging = "Paging",
}
Expand Down
9 changes: 0 additions & 9 deletions packages/base/src/types/ValueState.ts
Original file line number Diff line number Diff line change
@@ -1,45 +1,36 @@
/**
* Different types of ValueStates.
*
* @readonly
* @enum {string}
* @public
* @author SAP SE
* @alias sap.ui.webc.base.types.ValueState
*/
enum ValueState {
/**
*
* @public
* @type {None}
*/
None = "None",

/**
*
* @public
* @type {Success}
*/
Success = "Success",

/**
*
* @public
* @type {Warning}
*/
Warning = "Warning",

/**
*
* @public
* @type {Error}
*/
Error = "Error",

/**
*
* @public
* @type {Information}
*/
Information = "Information",
}
Expand Down
33 changes: 6 additions & 27 deletions packages/fiori/src/Bar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import slot from "@ui5/webcomponents-base/dist/decorators/slot.js";
import litRender from "@ui5/webcomponents-base/dist/renderer/LitRenderer.js";
import ResizeHandler from "@ui5/webcomponents-base/dist/delegate/ResizeHandler.js";
import BarDesign from "./types/BarDesign.js";
import type { IBar } from "./Interfaces";

// Template
import BarTemplate from "./generated/templates/BarTemplate.lit.js";
Expand All @@ -30,15 +31,6 @@ import BarCss from "./generated/themes/Bar.css.js";
* The default slot will be centered in the available space between the startContent and the endContent areas,
* therefore it might not always be centered in the entire bar.
*
* <h3>CSS Shadow Parts</h3>
*
* <ui5-link target="_blank" href="https://developer.mozilla.org/en-US/docs/Web/CSS/::part">CSS Shadow Parts</ui5-link> allow developers to style elements inside the Shadow DOM.
* <br>
* The <code>ui5-bar</code> exposes the following CSS Shadow Parts:
* <ul>
* <li>bar - Used to style the wrapper of the content of the component</li>
* </ul>
*
* <h3>Keyboard Handling</h3>
*
* <h4>Fast Navigation</h4>
Expand All @@ -51,12 +43,10 @@ import BarCss from "./generated/themes/Bar.css.js";
*
* <code>import "@ui5/webcomponents-fiori/dist/Bar.js";</code>
*
* @csspart bar - Used to style the wrapper of the content of the component
* @constructor
* @author SAP SE
* @alias sap.ui.webc.fiori.Bar
* @implements sap.ui.webc.fiori.IBar
* @extends sap.ui.webc.base.UI5Element
* @tagname ui5-bar
* @implements { IBar }
* @extends UI5Element
* @public
* @since 1.0.0-rc.11
*/
Expand All @@ -67,43 +57,32 @@ import BarCss from "./generated/themes/Bar.css.js";
styles: BarCss,
template: BarTemplate,
})
class Bar extends UI5Element {
class Bar extends UI5Element implements IBar {
/**
* Defines the component's design.
*
* @type {sap.ui.webc.fiori.types.BarDesign}
* @name sap.ui.webc.fiori.Bar.prototype.design
* @defaultvalue "Header"
* @default "Header"
* @public
*/
@property({ type: BarDesign, defaultValue: BarDesign.Header })
design!: `${BarDesign}`

/**
* Defines the content at the start of the bar.
* @type {HTMLElement[]}
* @name sap.ui.webc.fiori.Bar.prototype.startContent
* @slot
* @public
*/
@slot({ type: HTMLElement })
startContent!: Array<HTMLElement>;

/**
* Defines the content in the middle of the bar.
* @type {HTMLElement[]}
* @name sap.ui.webc.fiori.Bar.prototype.default
* @slot middleContent
* @public
*/
@slot({ type: HTMLElement, "default": true })
middleContent!: Array<HTMLElement>

/**
* Defines the content at the end of the bar.
* @type {HTMLElement[]}
* @name sap.ui.webc.fiori.Bar.prototype.endContent
* @slot
* @public
*/
@slot({ type: HTMLElement })
Expand Down
57 changes: 20 additions & 37 deletions packages/fiori/src/DynamicSideContent.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,12 +104,10 @@ type DynamicSideContentLayoutChangeEventDetail = {
* <code>import "@ui5/webcomponents-fiori/dist/DynamicSideContent";</code>
*
* @constructor
* @author SAP SE
* @alias sap.ui.webc.fiori.DynamicSideContent
* @extends sap.ui.webc.base.UI5Element
* @tagname ui5-dynamic-side-content
* @extends UI5Element
* @public
* @since 1.1.0
* @slot {HTMLElement[]} default - Defines the main content.
*/
@customElement({
tag: "ui5-dynamic-side-content",
Expand All @@ -119,7 +117,6 @@ type DynamicSideContentLayoutChangeEventDetail = {
})
/**
* Fires when the current breakpoint has been changed.
* @event sap.ui.webc.fiori.DynamicSideContent#layout-change
* @param {string} currentBreakpoint the current breakpoint.
* @param {string} previousBreakpoint the breakpoint that was active before change to current breakpoint.
* @param {boolean} mainContentVisible visibility of the main content.
Expand All @@ -128,15 +125,27 @@ type DynamicSideContentLayoutChangeEventDetail = {
*/
@event("layout-change", {
detail: {
/**
* @public
*/
currentBreakpoint: {
type: String,
},
/**
* @public
*/
previousBreakpoint: {
type: String,
},
/**
* @public
*/
mainContentVisible: {
type: Boolean,
},
/**
* @public
*/
sideContentVisible: {
type: Boolean,
},
Expand All @@ -146,9 +155,7 @@ class DynamicSideContent extends UI5Element {
/**
* Defines the visibility of the main content.
*
* @type {boolean}
* @name sap.ui.webc.fiori.DynamicSideContent.prototype.hideMainContent
* @defaultvalue false
* @default false
* @public
*
*/
Expand All @@ -158,9 +165,7 @@ class DynamicSideContent extends UI5Element {
/**
* Defines the visibility of the side content.
*
* @type {boolean}
* @name sap.ui.webc.fiori.DynamicSideContent.prototype.hideSideContent
* @defaultvalue false
* @default false
* @public
*
*/
Expand All @@ -179,9 +184,7 @@ class DynamicSideContent extends UI5Element {
* <li><code>End</code></li>
* </ul>
*
* @type {sap.ui.webc.fiori.types.SideContentPosition}
* @name sap.ui.webc.fiori.DynamicSideContent.prototype.sideContentPosition
* @defaultvalue "End"
* @default "End"
* @public
*
*/
Expand All @@ -202,9 +205,7 @@ class DynamicSideContent extends UI5Element {
* <li><code>NeverShow</code></li>
* </ul>
*
* @type {sap.ui.webc.fiori.types.SideContentVisibility}
* @name sap.ui.webc.fiori.DynamicSideContent.prototype.sideContentVisibility
* @defaultvalue "ShowAboveS"
* @default "ShowAboveS"
* @public
*
*/
Expand All @@ -224,9 +225,7 @@ class DynamicSideContent extends UI5Element {
* <li><code>OnMinimumWidth</code></li>
* </ul>
*
* @type {sap.ui.webc.fiori.types.SideContentFallDown}
* @name sap.ui.webc.fiori.DynamicSideContent.prototype.sideContentFallDown
* @defaultvalue "OnMinimumWidth"
* @default "OnMinimumWidth"
* @public
*
*/
Expand All @@ -239,9 +238,7 @@ class DynamicSideContent extends UI5Element {
* except for phone, where the main and side contents are switching visibility
* using the toggle method.
*
* @type {boolean}]
* @name sap.ui.webc.fiori.DynamicSideContent.prototype.equalSplit
* @defaultvalue false
* @default false
* @public
*
*/
Expand Down Expand Up @@ -272,21 +269,9 @@ class DynamicSideContent extends UI5Element {
@property({ noAttribute: true })
_currentBreakpoint!: string;

/**
* Defines the main content.
*
* @type {HTMLElement[]}
* @name sap.ui.webc.fiori.DynamicSideContent.prototype.default
* @slot
* @public
*/

/**
* Defines the side content.
*
* @type {HTMLElement[]}
* @name sap.ui.webc.fiori.DynamicSideContent.prototype.sideContent
* @slot
* @public
*/
@slot()
Expand Down Expand Up @@ -320,8 +305,6 @@ class DynamicSideContent extends UI5Element {
/**
* Toggles visibility of main and side contents on S screen size (mobile device).
* @public
NHristov-sap marked this conversation as resolved.
Show resolved Hide resolved
* @method
* @name sap.ui.webc.fiori.DynamicSideContent#toggleContents
*/
toggleContents() {
if (this.breakpoint === this.sizeS && this.sideContentVisibility !== SideContentVisibility.AlwaysShow) {
Expand Down
17 changes: 3 additions & 14 deletions packages/fiori/src/FilterItem.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,23 +18,17 @@ import type FilterItemOption from "./FilterItemOption.js";
* <code>import @ui5/webcomponents-fiori/dist/FilterItem.js";</code>
*
* @constructor
* @author SAP SE
* @alias sap.ui.webc.fiori.FilterItem
* @extends sap.ui.webc.base.UI5Element
* @extends UI5Element
* @abstract
* @since 1.0.0-rc.16
* @tagname ui5-filter-item
* @implements sap.ui.webc.fiori.IFilterItem
* @public
*/
@customElement("ui5-filter-item")
class FilterItem extends UI5Element {
/**
* Defines the text of the component.
*
* @name sap.ui.webc.fiori.FilterItem.prototype.text
* @type {string}
* @defaultvalue ""
* @default ""
* @public
*/
@property()
Expand All @@ -43,19 +37,14 @@ class FilterItem extends UI5Element {
/**
* Defines the additional text of the component.
*
* @name sap.ui.webc.fiori.FilterItem.prototype.additionalText
* @type {string}
* @defaultvalue ""
* @default ""
* @public
*/
@property()
additionalText!: string;

/**
* Defines the <code>values</code> list.
* @name sap.ui.webc.fiori.FilterItem.prototype.values
* @type {sap.ui.webc.fiori.IFilterItemOption[]}
* @slot values
* @public
*/
@slot()
Expand Down
Loading