docs: Adapt JSDocs for new CЕM and Remove Redundancies #7829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnaydenow
reviewed
Nov 22, 2023
There was a problem hiding this comment.
- accessibilityAttributes => Button.ts- default value is missing
- value => CalendarDate.ts- default value is missing
- value => ColorPaletteItem.ts- default value is missing
- defaultColor => ColorPalettePopover.ts - default value is missing
- showAt => ColorPalettePopover.ts - missing return type
- openPopover => ColorPalettePopover.ts - missing return type
- color => ColorPicker.ts- default value is missing
- primaryCalendarType => DateComponentBase.ts- default value is missing
- closePicker => DatePicker.ts - missing return type
- dateValue => DatePicker.ts- default value is missing
- dateValue => DateRangePicker.ts- default value is missing
- dateValueUTC => DateRangePicker.ts- default value is missing
- startDateValue => DateRangePicker.ts- default value is missing
- endDateValue => DateRangePicker.ts- default value is missing
- openPicker => DateTimePicker.ts - missing return type
- selectedDates => DayPicker.ts- default value is missing
- files => FileUploader.ts- default value is missing
- accessibilityAttributes => Link.ts- default value is missing
- showAt => Menu.ts - missing return type
- close => Menu.ts - missing return type
- additionalText => MenuItem.ts- default value is missing
- selectedDates => MonthPicker.ts- default value is missing
- selectedItem => SegmentedButton.ts- default value is missing
- selectedItems => SegmentedButton.ts- default value is missing
- min => StepInput.ts- default value is missing
- max => StepInput.ts- default value is missing
- accessibleName => StepInput.ts- default value is missing
- dateValue => TimePicker.ts- default value is missing
- hideHours => TimeSelection.ts- default value is missing
- hideMinutes => TimeSelection.ts- default value is missing
- hideSeconds => TimeSelection.ts- default value is missing
- maxHours => TimeSelection.ts- default value is missing
- maxMinutes => TimeSelection.ts- default value is missing
- maxSeconds => TimeSelection.ts- default value is missing
- selectedDates => YearPicker.ts- default value is missing
hinzzx
reviewed
Nov 22, 2023
hinzzx
reviewed
Nov 22, 2023
hinzzx
reviewed
Nov 22, 2023
hinzzx
reviewed
Nov 22, 2023
nnaydenow
requested changes
Nov 26, 2023
There was a problem hiding this comment.
Everything else looks okay. Need to revise interfaces and some of the changes with @tsanislavgatev and we can proceed with merge
* fix(ui5-textarea): improve documentation * docs(ui5-textarea): reflect comments
* fix(ui5-slider, ui5-range-slider): enhance documentation * docs(ui5-slider, ui5-range-slider): reflect review comments
* docs: new cem for Topic-P components - Toolbar Issue: #7610 * docs: new cem for Topic-P components - Toolbar -refactored toolbar related files docs * docs: new cem for Topic-P components - Toolbar - removed unnecessary tag rom ToolbarSeparator docs * docs: new cem for Topic-P components - Toolbar -fixed review comments * docs: new cem for Topic-P components - Toolbar - fixed review comments * docs: new cem for Topic-P components - Toolbar - fixed review comments * docs: new cem for Topic-P components - Toolbar - fixed review comments * docs: new cem for Topic-P components - Toolbar - fixed review comments * docs: new cem for Topic-P components - Toolbar - fixed review comments
* docs: new cem for Topic-P components - List Issue: #7610 * docs: new cem for Topic-P components - List - fixed review comments * docs: new cem for Topic-P components - List - fixed review comments * docs: new cem for Topic-P components - List - fixed review comments * docs: new cem for Topic-P components - List - fixed review comments
|
Will continue work in #7922 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt JSDocs for new CЕM and Remove Redundancies
Related to: #7610