[INTERNAL] docs/pages/Builder.md: Explain bundling of files requiring top level scope #975
+24
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flovogt
force-pushed
the
builder-bundle-docu
branch
from
19a529b
to
0219f7f
Compare
RandomByte
requested changes
Jul 8, 2024
KlattG
suggested changes
Jul 9, 2024
codeworrior
reviewed
Jul 9, 2024
There was a problem hiding this comment.
LGTM.
There are more solution variants that could be mentioned, but I like the limitation to these two as they are the future-proof ones.
Others:
- add a filter to exclude the module from bundling
- (already marked as "not recommended" in the BLI) use the
requiresTopLevelScopeandignoredGlobalsconfig in the .library
RandomByte
previously approved these changes
Jul 9, 2024
matz3
reviewed
Jul 11, 2024
There was a problem hiding this comment.
Maybe include the actual error message text somewhere so that people will find it via search engines when running into this issue?
People will mainly come across this documentation after they see the error in the log (also see my comment in the implementation PR)
… top level scope JIRA: CPOUI5FOUNDATION-794
Co-authored-by: Merlin Beutlberger <[email protected]>
Co-authored-by: Günter Klatt <[email protected]>
flovogt
force-pushed
the
builder-bundle-docu
branch
from
286400f
to
87cb717
Compare
matz3
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a section about old (specVersion < 4) and new (specVersion <= 4) behavior when bundling files requiring top level scope.
JIRA: CPOUI5FOUNDATION-794