-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING] Discontinue bundling of JavaScript modules as string #1036
Conversation
fc7d29e
to
b9217ff
Compare
ea6f16b
to
f617f0b
Compare
2b4a4dc
to
8791491
Compare
09b6663
to
88bcad2
Compare
88bcad2
to
f8e4b88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing some tests for the case of specVersion 4 project with resources that require bundling as string
f8e4b88
to
2781bfe
Compare
6faad79
to
fc4fe78
Compare
ui5 tooling integration tests are triggered: 534 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0402336
to
f94939d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flovogt I think I've seen 'higher' more often than 'newer'.
f94939d
to
2eeb1b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2eeb1b4
to
7cb8f6b
Compare
7cb8f6b
to
79e38a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor point, otherwise LGTM
79e38a5
to
0527308
Compare
The UI5 bundler packages JavaScript files that are identified as "requiresTopLevelScope" as a string, to be evaluated via "eval" at runtime. This behavior ensures that the script works as expected, e.g. with regards to implicit globals. This "eval" runtime feature with be discontinued in UI5 2.0 because of security best practices (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/eval) and to comply with stricter CSP settings (unsafe-eval). By using specVersion 4.0 an error is thrown when bundling a module as string and the module is not included in the bundle at all. JIRA: CPOUI5FOUNDATION-794
0527308
to
db37a49
Compare
The UI5 bundler packages JavaScript files that are identified as "requiresTopLevelScope" as a string, to be evaluated via "eval" at runtime. This behavior ensures that the script works as expected, e.g. with regards to implicit globals.
This "eval" runtime feature with be discontinued in UI5 2.0 because of security best practices (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/eval) and to comply with stricter CSP settings (unsafe-eval).
By using specVersion 4.0 an error is thrown when bundling a module as string and the module is not included in the bundle at all.
JIRA: CPOUI5FOUNDATION-794