Removed all @Beta annotations #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlesDuboisSAP
added
please merge
newtork
reviewed
Nov 12, 2024
cloudplatform/caching/src/main/java/com/sap/cloud/sdk/cloudplatform/cache/CacheKey.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Nov 12, 2024
...rm/cloudplatform-core/src/main/java/com/sap/cloud/sdk/cloudplatform/thread/LazyProperty.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Nov 12, 2024
...ient5/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/ApacheHttpClient5Cache.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Nov 12, 2024
...rc/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/ApacheHttpClient5CacheBuilder.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Nov 12, 2024
.../main/java/com/sap/cloud/sdk/cloudplatform/connectivity/ApacheHttpClient5FactoryBuilder.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Nov 12, 2024
...in/java/com/sap/cloud/sdk/cloudplatform/connectivity/DestinationServiceOptionsAugmenter.java
Show resolved
Hide resolved
newtork
reviewed
Nov 12, 2024
| @@ -30,7 +29,6 @@ | |||
| * Serializable and deserializable response type for SCP CF Destination Service queries. | |||
| */ | |||
| @Data | |||
| @Beta | |||
| public class DestinationServiceV1Response | |||
There was a problem hiding this comment.
While I'm fine with this being stable, the @Beta at least warned users from using this class:
We can't guarantee API stability for Destination Service response.
newtork
reviewed
Nov 12, 2024
| @@ -22,7 +21,6 @@ | |||
| /** | |||
| * Utility class to extract specific values from the SAP Deploy with Confidence request headers. | |||
| */ | |||
| @Beta | |||
| public class DwcHeaderUtils | |||
There was a problem hiding this comment.
Do we want to keep the class name?
IMHO "utils" doesn't really fit when interacting with accessor classes. In my head "utils" are working stateless. Debatable.
newtork
reviewed
Nov 12, 2024
...-dwc/src/main/java/com/sap/cloud/sdk/cloudplatform/exception/DwcHeaderNotFoundException.java
Show resolved
Hide resolved
newtork
reviewed
Nov 12, 2024
| import io.vavr.control.Try; | ||
|
|
||
| @Beta | ||
| interface MavenRepositoryAccessor |
There was a problem hiding this comment.
(Comment)
I thought we could remove metadata generator module, but it seems we are using this for common code between v2 and v4 generators.
newtork
reviewed
Nov 18, 2024
Co-authored-by: Alexander Dümont <[email protected]>
newtork
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related ticket:
https://github.com/SAP/cloud-sdk-java-backlog/issues/461