Skip to content

Commit

Permalink
Removed all @beta annotations (#637)
Browse files Browse the repository at this point in the history
Co-authored-by: Alexander Dümont <[email protected]>
  • Loading branch information
CharlesDuboisSAP and newtork authored Nov 18, 2024
1 parent f94f577 commit ef0b4ff
Show file tree
Hide file tree
Showing 32 changed files with 8 additions and 89 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
import javax.annotation.Nullable;

import com.github.benmanes.caffeine.cache.Cache;
import com.google.common.annotations.Beta;
import com.google.common.collect.ImmutableList;
import com.sap.cloud.sdk.cloudplatform.security.principal.Principal;
import com.sap.cloud.sdk.cloudplatform.security.principal.PrincipalAccessor;
Expand Down Expand Up @@ -70,7 +69,6 @@ public static synchronized <T> Cache<CacheKey, T> register( @Nonnull final Cache
* @return The given cache.
* @since 4.3.0
*/
@Beta
@Nonnull
public static synchronized <T> Cache<CacheKey, T> unregister( @Nonnull final Cache<CacheKey, T> cache )
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
import java.util.Collection;
import java.util.List;

import com.google.common.annotations.Beta;
import com.sap.cloud.sdk.cloudplatform.servlet.LocaleAccessor;

/**
Expand Down Expand Up @@ -139,7 +138,6 @@ public class DestinationProperty
/**
* Principal Propagation Strategy of destination, in case of Proxy Type = On-Premise.
*/
@Beta
public static final DestinationPropertyKey<PrincipalPropagationMode> PRINCIPAL_PROPAGATION_MODE =
createProperty(
"cloudsdk.principalPropagationMode",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
import javax.annotation.Nonnull;
import javax.annotation.Nullable;

import com.google.common.annotations.Beta;

import lombok.Getter;

/**
Expand Down Expand Up @@ -60,7 +58,6 @@ public static SecurityConfigurationStrategy getDefault()
* @throws IllegalArgumentException
* if no {@link SecurityConfigurationStrategy} could be found for the given identifier.
*/
@Beta
@Nonnull
public static SecurityConfigurationStrategy ofIdentifierOrDefault( @Nullable final String identifier )
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,11 @@
import javax.annotation.Nonnull;
import javax.net.ssl.SSLContext;

import com.google.common.annotations.Beta;

import io.vavr.control.Try;

/**
* Creates an SslContext based on properties of the platform.
*/
@Beta
@FunctionalInterface
public interface PlatformSslContextProvider
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

import org.apache.http.client.HttpClient;

import com.google.common.annotations.Beta;
import com.sap.cloud.sdk.cloudplatform.connectivity.exception.HttpClientInstantiationException;

import io.vavr.control.Try;
Expand Down Expand Up @@ -55,7 +54,6 @@ Try<HttpClient> tryGetHttpClient(
* Constant implementation of {@see HttpClientCache} with disabled the cache logic. Useful for testing and
* troubleshooting. Don't use in production.
*/
@Beta
@Nonnull
HttpClientCache DISABLED = new HttpClientCache()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ public ApacheHttpClient5FactoryBuilder maxConnectionsTotal( final int maxConnect
*
* @since 5.14.0
*/
@Beta
@Nonnull
public ApacheHttpClient5FactoryBuilder tlsUpgrade( @Nonnull final TlsUpgrade tlsUpgrade )
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import org.apache.commons.lang3.exception.ExceptionUtils;

import com.github.benmanes.caffeine.cache.Caffeine;
import com.google.common.annotations.Beta;
import com.google.common.collect.Streams;
import com.google.gson.Gson;
import com.google.gson.JsonElement;
Expand Down Expand Up @@ -389,7 +388,6 @@ private static boolean hasCauseAssignableFrom( @Nonnull final Throwable t, @Nonn
* @since 4.3.0
*/
@Slf4j
@Beta
public static final class Cache
{
/**
Expand Down Expand Up @@ -657,7 +655,6 @@ public static void disableExpiration()
*
* @since 4.7.0
*/
@Beta
@Deprecated
public static void enableChangeDetection()
{
Expand Down Expand Up @@ -696,7 +693,6 @@ Therefore, the default expiration ({}{}) will be restored.\
*
* @since 5.2.0
*/
@Beta
public static void disableChangeDetection()
{
throwIfDisabled();
Expand Down Expand Up @@ -905,7 +901,6 @@ private static void throwIfDisabled()
* @return A builder to prepare a customised instance.
* @since 4.4.0
*/
@Beta
@Nonnull
public static Builder builder()
{
Expand All @@ -917,7 +912,6 @@ public static Builder builder()
*
* @since 4.4.0
*/
@Beta
@NoArgsConstructor( access = AccessLevel.PRIVATE )
public static final class Builder
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@

import javax.annotation.Nonnull;

import com.google.common.annotations.Beta;

import io.vavr.control.Option;
import lombok.NoArgsConstructor;
import lombok.extern.slf4j.Slf4j;
Expand Down Expand Up @@ -79,7 +77,6 @@ public DestinationServiceOptionsAugmenter tokenExchangeStrategy(
* @return The same augmenter that called this method.
* @since 5.9.0
*/
@Beta
@Nonnull
public DestinationServiceOptionsAugmenter refreshToken( @Nonnull final String refreshToken )
{
Expand All @@ -95,7 +92,6 @@ public DestinationServiceOptionsAugmenter refreshToken( @Nonnull final String re
* @return The same augmenter that called this method.
* @since 5.11.0
*/
@Beta
@Nonnull
public DestinationServiceOptionsAugmenter fragmentName( @Nonnull final String fragmentName )
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
import javax.annotation.Nonnull;
import javax.annotation.Nullable;

import com.google.common.annotations.Beta;
import com.google.common.collect.Maps;
import com.google.gson.JsonDeserializationContext;
import com.google.gson.JsonDeserializer;
Expand All @@ -30,7 +29,6 @@
* Serializable and deserializable response type for SCP CF Destination Service queries.
*/
@Data
@Beta
public class DestinationServiceV1Response
{
@SerializedName( "owner" )
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
import javax.annotation.Nonnull;
import javax.annotation.Nullable;

import com.google.common.annotations.Beta;
import com.google.common.base.Strings;
import com.google.gson.Gson;
import com.sap.cloud.sdk.cloudplatform.exception.DwcHeaderNotFoundException;
Expand All @@ -22,7 +21,6 @@
/**
* Utility class to extract specific values from the SAP Deploy with Confidence request headers.
*/
@Beta
public class DwcHeaderUtils
{
/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
import javax.annotation.Nonnull;
import javax.annotation.Nullable;

import com.google.common.annotations.Beta;
import com.sap.cloud.environment.servicebinding.api.ServiceBinding;
import com.sap.cloud.environment.servicebinding.api.ServiceIdentifier;
import com.sap.cloud.sdk.cloudplatform.exception.CloudPlatformException;
Expand Down Expand Up @@ -54,7 +53,6 @@
* @see MegacliteServiceBindingAccessor#registerServiceBinding(MegacliteServiceBinding)
* @since 4.17.0
*/
@Beta
@Getter( AccessLevel.PACKAGE )
@RequiredArgsConstructor( access = AccessLevel.PRIVATE )
@EqualsAndHashCode
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,9 @@

import javax.annotation.Nonnull;

import com.google.common.annotations.Beta;

/**
* Represents an {@link Throwable} that is thrown if a specific Deploy with Confidence header was not found.
*/
@Beta
public class DwcHeaderNotFoundException extends RuntimeException
{
private static final long serialVersionUID = 1089454219933367075L;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import javax.annotation.Nonnull;
import javax.annotation.Nullable;

import com.google.common.annotations.Beta;
import com.sap.cloud.sdk.cloudplatform.DwcHeaderUtils;
import com.sap.cloud.sdk.cloudplatform.security.principal.DefaultPrincipal;
import com.sap.cloud.sdk.cloudplatform.security.principal.DefaultPrincipalFacade;
Expand All @@ -22,7 +21,6 @@
* Represents a specific {@link DefaultPrincipalFacade} that is used when running on the SAP Deploy with Confidence
* stack.
*/
@Beta
public class DwcPrincipalFacade extends DefaultPrincipalFacade
{
private static final String PRINCIPAL = PrincipalThreadContextListener.PROPERTY_PRINCIPAL;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import javax.annotation.Nonnull;
import javax.annotation.Nullable;

import com.google.common.annotations.Beta;
import com.sap.cloud.sdk.cloudplatform.DwcHeaderUtils;
import com.sap.cloud.sdk.cloudplatform.tenant.exception.TenantAccessException;
import com.sap.cloud.sdk.cloudplatform.thread.ThreadContext;
Expand All @@ -17,7 +16,6 @@
/**
* Represents a specific {@link DefaultTenantFacade} that is used when running on the SAP Deploy with Confidence stack.
*/
@Beta
public class DwcTenantFacade extends DefaultTenantFacade
{
private static final String TENANT = TenantThreadContextListener.PROPERTY_TENANT;
Expand Down
9 changes: 5 additions & 4 deletions cloudplatform/connectivity-oauth/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,6 @@
<artifactId>jcl-over-slf4j</artifactId>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</dependency>
<dependency>
<groupId>com.auth0</groupId>
<artifactId>java-jwt</artifactId>
Expand Down Expand Up @@ -196,6 +192,11 @@
<artifactId>testutil</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<scope>test</scope>
</dependency>
</dependencies>
<build>
<plugins>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
import javax.annotation.Nonnull;
import javax.annotation.Nullable;

import com.google.common.annotations.Beta;
import com.sap.cloud.environment.servicebinding.api.TypedMapView;
import com.sap.cloud.sdk.cloudplatform.connectivity.SecurityLibWorkarounds.ZtisClientIdentity;
import com.sap.cloud.sdk.cloudplatform.connectivity.exception.DestinationAccessException;
Expand All @@ -37,7 +36,6 @@
*
* @since 4.20.0
*/
@Beta
@Slf4j
public class DefaultOAuth2PropertySupplier implements OAuth2PropertySupplier
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import javax.annotation.Nonnull;
import javax.annotation.Nullable;

import com.google.common.annotations.Beta;
import com.sap.cloud.environment.servicebinding.api.ServiceBinding;
import com.sap.cloud.environment.servicebinding.api.ServiceIdentifier;
import com.sap.cloud.environment.servicebinding.api.TypedMapView;
Expand All @@ -25,7 +24,6 @@
*
* @since 5.6.0
*/
@Beta
@Slf4j
public class IdentityAuthenticationServiceBindingDestinationLoader implements ServiceBindingDestinationLoader
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

import org.apache.http.HttpHeaders;

import com.google.common.annotations.Beta;
import com.sap.cloud.security.config.ClientIdentity;

import lombok.extern.slf4j.Slf4j;
Expand All @@ -20,7 +19,6 @@
* @since 4.10.0
*/
@Slf4j
@Beta
public class OAuth2DestinationBuilder
{
/**
Expand All @@ -29,7 +27,6 @@ public class OAuth2DestinationBuilder
* @since 4.10.0
*/
@FunctionalInterface
@Beta
public interface BuilderWithTargetUrl
{
/**
Expand All @@ -50,7 +47,6 @@ public interface BuilderWithTargetUrl
* @since 4.10.0
*/
@FunctionalInterface
@Beta
public interface BuilderWithTokenEndpoint
{
/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
import javax.annotation.Nonnull;
import javax.annotation.Nullable;

import com.google.common.annotations.Beta;
import com.sap.cloud.sdk.cloudplatform.connectivity.ServiceBindingDestinationOptions.OptionsEnhancer;
import com.sap.cloud.sdk.cloudplatform.resilience.ResilienceConfiguration.TimeLimiterConfiguration;

Expand All @@ -24,7 +23,6 @@
*
* @since 5.5.0
*/
@Beta
@AllArgsConstructor( access = AccessLevel.PRIVATE )
@EqualsAndHashCode
public final class OAuth2Options
Expand Down Expand Up @@ -96,7 +94,6 @@ public static Builder builder()
/**
* A builder implementation that helps with creating customized {@link OAuth2Options} instances.
*/
@Beta
@Slf4j
public static class Builder
{
Expand Down
4 changes: 0 additions & 4 deletions cloudplatform/connectivity-ztis/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,6 @@
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</dependency>
<dependency>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

import javax.annotation.Nonnull;

import com.google.common.annotations.Beta;
import com.sap.cloud.environment.servicebinding.api.DefaultServiceBindingAccessor;
import com.sap.cloud.environment.servicebinding.api.ServiceBinding;
import com.sap.cloud.environment.servicebinding.api.ServiceIdentifier;
Expand Down Expand Up @@ -42,7 +41,6 @@
*
* @since 5.7.0
*/
@Beta
@Slf4j
@RequiredArgsConstructor( access = AccessLevel.PRIVATE )
public class ZeroTrustIdentityService
Expand Down
Loading

0 comments on commit ef0b4ff

Please sign in to comment.