Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port] Shitmed #868

Merged
merged 9 commits into from
Oct 29, 2024
Merged

[Port] Shitmed #868

merged 9 commits into from
Oct 29, 2024

Conversation

Roudenn
Copy link
Collaborator

@Roudenn Roudenn commented Oct 29, 2024

просто непонятный порт с изменением 6 тысяч строк, ничего интересного
Порт с Simple-Station/Einstein-Engines#1159

@Roudenn Roudenn requested a review from Rxup as a code owner October 29, 2024 13:28
@github-actions github-actions bot added Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation labels Oct 29, 2024
Copy link
Contributor

github-actions bot commented Oct 29, 2024

RSI Diff Bot; head commit d56eead merging into 402691f
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Interface/Targeting/Status/head.rsi

State Old New Status
head_0 Added
head_1 Added
head_2 Added
head_3 Added
head_4 Added
head_5 Added
head_6 Added
head_7 Added
head_8 Added

Resources/Textures/Interface/Targeting/Status/leftarm.rsi

State Old New Status
leftarm_0 Added
leftarm_1 Added
leftarm_2 Added
leftarm_3 Added
leftarm_4 Added
leftarm_5 Added
leftarm_6 Added
leftarm_7 Added
leftarm_8 Added

Resources/Textures/Interface/Targeting/Status/leftleg.rsi

State Old New Status
leftleg_0 Added
leftleg_1 Added
leftleg_2 Added
leftleg_3 Added
leftleg_4 Added
leftleg_5 Added
leftleg_6 Added
leftleg_7 Added
leftleg_8 Added

Resources/Textures/Interface/Targeting/Status/rightarm.rsi

State Old New Status
rightarm_0 Added
rightarm_1 Added
rightarm_2 Added
rightarm_3 Added
rightarm_4 Added
rightarm_5 Added
rightarm_6 Added
rightarm_7 Added
rightarm_8 Added

Resources/Textures/Interface/Targeting/Status/rightleg.rsi

State Old New Status
rightleg_0 Added
rightleg_1 Added
rightleg_2 Added
rightleg_3 Added
rightleg_4 Added
rightleg_5 Added
rightleg_6 Added
rightleg_7 Added
rightleg_8 Added

Resources/Textures/Interface/Targeting/Status/torso.rsi

State Old New Status
torso_0 Added
torso_1 Added
torso_2 Added
torso_3 Added
torso_4 Added
torso_5 Added
torso_6 Added
torso_7 Added
torso_8 Added

Resources/Textures/Objects/Specific/Medical/Surgery/bone_gel.rsi

State Old New Status
bone-gel Added
bone-gel_0 Added
bone-gel_25 Added
bone-gel_50 Added
bone-gel_75 Added
predator_bone-gel Added

Resources/Textures/Objects/Specific/Medical/Surgery/bonesetter.rsi

State Old New Status
bonesetter Added
predator_bonesetter Added

Resources/Textures/Objects/Specific/Medical/Surgery/manipulation.rsi

State Old New Status
insertion Added

Resources/Textures/Structures/Machines/limbgrower.rsi

State Old New Status
limbgrower_fill Added
limbgrower_idleoff Added
limbgrower_idleon Added
limbgrower_openpanel Added
limbgrower_panelopen Added
limbgrower_unfill Added

Edit: diff updated after d56eead

@gluesniffler
Copy link
Contributor

Bold. If you're trying to get the tests to pass, I recommend putting your eye on one thing.

  • SharedBodySystem.Parts.RemovePartEffect: This is shitcode, and the cause for 90% of the test fails. But I basically placed it at a point where it wouldnt crash the server for players due to null references when trying to cycle through the entities via the OnBodyPartRemoved function... However tests do not like it. It should be refactored somehow to be within RecursiveBodyUpdate, as it does something very similar (drop parts recursively), and would save us the work of iterating.

Before I updated to the latest EE master branch I also had issues with BodyPartComponent's auto-generated state, no clue if its still being annoying.

My DMs are open if you'd like more info or something :trollface:

@trest100
Copy link
Contributor

Bold. If you're trying to get the tests to pass, I recommend putting your eye on one thing.

  • SharedBodySystem.Parts.RemovePartEffect: This is shitcode, and the cause for 90% of the test fails. But I basically placed it at a point where it wouldnt crash the server for players due to null references when trying to cycle through the entities via the OnBodyPartRemoved function... However tests do not like it. It should be refactored somehow to be within RecursiveBodyUpdate, as it does something very similar (drop parts recursively), and would save us the work of iterating.

Before I updated to the latest EE master branch I also had issues with BodyPartComponent's auto-generated state, no clue if its still being annoying.

My DMs are open if you'd like more info or something :trollface:

hi, we have almost figured out the tests and rewrote part of your system, now it is more optimized, today we will test on the server
We also have our own developments on the simulation of the circulatory and nervous systems, we will try to integrate them. Thank you again for making the dream of thousands of people come true!

@trest100
Copy link
Contributor

Bold. If you're trying to get the tests to pass, I recommend putting your eye on one thing.

  • SharedBodySystem.Parts.RemovePartEffect: This is shitcode, and the cause for 90% of the test fails. But I basically placed it at a point where it wouldnt crash the server for players due to null references when trying to cycle through the entities via the OnBodyPartRemoved function... However tests do not like it. It should be refactored somehow to be within RecursiveBodyUpdate, as it does something very similar (drop parts recursively), and would save us the work of iterating.

Before I updated to the latest EE master branch I also had issues with BodyPartComponent's auto-generated state, no clue if its still being annoying.

My DMs are open if you'd like more info or something :trollface:

^~^

@Rxup Rxup merged commit addc520 into Rxup:master Oct 29, 2024
11 checks passed
@gluesniffler
Copy link
Contributor

gluesniffler commented Oct 29, 2024

Thank you for the help! I'll be checking out the changes and porting them to the upstream PR after testing em myself. Please be sure to report any bugs or weirdness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants